(moneta) Fix MonetaMoneyModule.getModuleName() returning "JavaxMoneyModule" - #93
Open
pjfanning wants to merge 2 commits into
Open
(moneta) Fix MonetaMoneyModule.getModuleName() returning "JavaxMoneyModule"#93pjfanning wants to merge 2 commits into
MonetaMoneyModule.getModuleName() returning "JavaxMoneyModule"#93pjfanning wants to merge 2 commits into
Conversation
…yModule" Copy-paste slip: the override returns `JavaxMoneyModule.class.getSimpleName()`, so `MonetaMoneyModule` reports itself under the base module's name. Module registration is unaffected -- `getRegistrationId()` correctly resolves to `tools.jackson.datatype.moneta.MonetaMoneyModule`, so there is no dedup collision -- but the name is wrong everywhere it is reported. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Copy-paste slip in
MonetaMoneyModule:So the module reports itself under the base module's name:
Registration itself is fine —
getRegistrationId()correctly resolves totools.jackson.datatype.moneta.MonetaMoneyModule, so there is no duplicate-registration collision between the two modules — but the name is wrong everywhere it gets reported.Fix
Return
MonetaMoneyModule.class.getSimpleName().Tests
New
ModuleNameTest: asserts the moneta module's own name, that it differs from the base module's, and thatJavaxMoneyModulekeeps its (already correct) name.javax-money135 tests andmoneta140 tests all green.