Skip to content

Report bad CurrencyUnit input as databind exception rather than UnknownCurrencyException/NPE #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cowtowncoder merged 6 commits into from
Sep 15, 2026
+25 −1
Merged

Report bad CurrencyUnit input as databind exception rather than UnknownCurrencyException/NPE #95

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f72d468
(javax-money) Report bad `CurrencyUnit` input as databind exception, …
pjfanning Sep 9, 2026
3d78013
Add release notes entry for #95
pjfanning Sep 9, 2026
a4b5a9c
Merge branch '3.x' into fix-javax-money-currency-token-handling
cowtowncoder Sep 15, 2026
c800c96
Merge branch '3.x' into fix-javax-money-currency-token-handling
cowtowncoder Sep 15, 2026
3b3c087
Merge branch '3.x' into fix-javax-money-currency-token-handling
cowtowncoder Sep 15, 2026
846eabf
...
cowtowncoder Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion moneta/src/test/java/tools/jackson/datatype/moneta/CurrencyUnitDeserializerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

import tools.jackson.databind.ObjectMapper;
import tools.jackson.databind.exc.InvalidFormatException;
import tools.jackson.databind.exc.MismatchedInputException;
import tools.jackson.databind.json.JsonMapper;
import tools.jackson.databind.jsontype.BasicPolymorphicTypeValidator;

Expand All @@ -29,10 +30,29 @@ public void shouldDeserialize() throws Exception {
@Test
public void shouldNotDeserializeInvalidCurrency() {
final InvalidFormatException e = assertThrows(InvalidFormatException.class, () ->
unit.readValue("\"FOO\"", CurrencyUnit.class));
unit.readValue(a2q("'FOO'"), CurrencyUnit.class));
assertThat(e.getMessage()).contains("FOO");
assertThat(e.getValue()).isEqualTo("FOO");
}

@Test
public void shouldNotDeserializeFromNumber() {
assertThrows(MismatchedInputException.class, () ->
unit.readValue("12", CurrencyUnit.class));
}

@Test
public void shouldNotDeserializeFromObject() {
assertThrows(MismatchedInputException.class, () ->
unit.readValue(a2q("{'a':1}"), CurrencyUnit.class));
}

@Test
public void shouldNotDeserializeFromArray() {
assertThrows(MismatchedInputException.class, () ->
unit.readValue("[1,2]", CurrencyUnit.class));
}

@Test
public void shouldDeserializeWithTyping() throws Exception {
ObjectMapper mapper = JsonMapper.builder()
Expand All @@ -45,4 +65,8 @@ public void shouldDeserializeWithTyping() throws Exception {

assertThat(actual).isEqualTo(expected);
}

private static String a2q(final String json) {
return json.replace("'", "\"");
}
}
Loading