Skip to content

fix(ci): exclude filecoin-services from binary cache key#109

Merged
rvagg merged 2 commits into
mainfrom
copilot/fix-stability-scenarios-run
May 7, 2026
Merged

fix(ci): exclude filecoin-services from binary cache key#109
rvagg merged 2 commits into
mainfrom
copilot/fix-stability-scenarios-run

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 6, 2026

Two bugs combined to cause the stability run failures: init_flags was defined as a workflow input but never forwarded to ./foc-devnet init, so --filecoin-services latesttag:v* was silently ignored. Both stability and frontier always deployed the hardcoded default — commit c79e2c6b (pre-v1.2.0) — which lacks the paginated getClientDataSets(address,uint256,uint256) that synapse-sdk now calls. The result: unknown function selector → EVM fallback → revert (exit 33).

Changes

  • ci_run.yml — forward init_flags: Both ./foc-devnet init paths (Docker-cache-hit and miss) now receive ${{ inputs.init_flags }}:

    ./foc-devnet init --no-docker-build ${{ inputs.init_flags }}
    ./foc-devnet init ${{ inputs.init_flags }}
  • ci_run.yml — narrow CODE_HASH to lotus/curio only: filecoin-services contains Solidity contracts compiled by Foundry at deploy time — changing its version should not bust the Lotus/Curio binary cache:

    CODE_HASH=$(echo "$VERSION_OUTPUT" | grep -E 'default:code:(lotus|curio)' | sha256sum | ...)
  • config.rs — update default filecoin_services to v1.2.0: Fixes PR CI runs (which use no init_flags) by ensuring the deployed StateView includes the paginated API the synapse-sdk requires:

    filecoin_services: Location::GitTag {
        url: "https://github.com/FilOzone/filecoin-services.git".to_string(),
        tag: "v1.2.0".to_string(),
    },

Copilot AI linked an issue May 6, 2026 that may be closed by this pull request
@BigLep BigLep added this to FOC May 6, 2026
@github-project-automation github-project-automation Bot moved this to 📌 Triage in FOC May 6, 2026
Copilot AI changed the title [WIP] Fix stability scenarios run failures Fix stability CI: forward init_flags to foc-devnet init and update default filecoin-services to v1.2.0 May 6, 2026
Copilot finished work on behalf of BigLep May 6, 2026 03:59
Copilot AI requested a review from BigLep May 6, 2026 03:59
@BigLep BigLep moved this from 📌 Triage to ⌨️ In Progress in FOC May 6, 2026
@rvagg rvagg marked this pull request as ready for review May 7, 2026 09:15
Copilot AI review requested due to automatic review settings May 7, 2026 09:15
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes stability/frontier CI failures by ensuring version override flags are actually applied during initialization, and by updating the default filecoin-services version to a tag that includes the paginated API expected by newer synapse-sdk calls.

Changes:

  • Forward the reusable workflow input init_flags to both cached and non-cached ./foc-devnet init invocations.
  • Adjust the CI CODE_HASH computation to consider only Lotus/Curio default code versions (so filecoin-services bumps don’t invalidate the Lotus/Curio binary cache).
  • Update Config::default() to pin filecoin_services to v1.2.0.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/config.rs Updates default filecoin_services from a pinned commit to the v1.2.0 tag to match expected contract APIs.
.github/workflows/ci_run.yml Fixes CI by forwarding init_flags to foc-devnet init and narrowing CODE_HASH to Lotus/Curio.

@github-project-automation github-project-automation Bot moved this from ⌨️ In Progress to ✔️ Approved by reviewer in FOC May 7, 2026
@rvagg rvagg force-pushed the copilot/fix-stability-scenarios-run branch from 961e9eb to 0595ad6 Compare May 7, 2026 13:29
@rvagg rvagg changed the title Fix stability CI: forward init_flags to foc-devnet init and update default filecoin-services to v1.2.0 fix(ci): exclude filecoin-services from binary cache key May 7, 2026
@rvagg rvagg merged commit 9a42ccf into main May 7, 2026
3 checks passed
@rvagg rvagg deleted the copilot/fix-stability-scenarios-run branch May 7, 2026 13:36
@github-project-automation github-project-automation Bot moved this from ✔️ Approved by reviewer to 🎉 Done in FOC May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

FOC Devnet scenarios run report (stability)

4 participants