fix(ci): exclude filecoin-services from binary cache key#109
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix stability scenarios run failures
Fix stability CI: forward init_flags to foc-devnet init and update default filecoin-services to v1.2.0
May 6, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes stability/frontier CI failures by ensuring version override flags are actually applied during initialization, and by updating the default filecoin-services version to a tag that includes the paginated API expected by newer synapse-sdk calls.
Changes:
- Forward the reusable workflow input
init_flagsto both cached and non-cached./foc-devnet initinvocations. - Adjust the CI
CODE_HASHcomputation to consider only Lotus/Curio default code versions (sofilecoin-servicesbumps don’t invalidate the Lotus/Curio binary cache). - Update
Config::default()to pinfilecoin_servicestov1.2.0.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/config.rs |
Updates default filecoin_services from a pinned commit to the v1.2.0 tag to match expected contract APIs. |
.github/workflows/ci_run.yml |
Fixes CI by forwarding init_flags to foc-devnet init and narrowing CODE_HASH to Lotus/Curio. |
rvagg
approved these changes
May 7, 2026
…n-services to v1.2.0 Agent-Logs-Url: https://github.com/FilOzone/foc-devnet/sessions/15ee3dbb-01ad-43ee-b68e-139b526a6c9f Co-authored-by: BigLep <85411+BigLep@users.noreply.github.com>
961e9eb to
0595ad6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs combined to cause the stability run failures:
init_flagswas defined as a workflow input but never forwarded to./foc-devnet init, so--filecoin-services latesttag:v*was silently ignored. Both stability and frontier always deployed the hardcoded default — commitc79e2c6b(pre-v1.2.0) — which lacks the paginatedgetClientDataSets(address,uint256,uint256)that synapse-sdk now calls. The result: unknown function selector → EVM fallback → revert (exit 33).Changes
ci_run.yml— forwardinit_flags: Both./foc-devnet initpaths (Docker-cache-hit and miss) now receive${{ inputs.init_flags }}:ci_run.yml— narrowCODE_HASHto lotus/curio only: filecoin-services contains Solidity contracts compiled by Foundry at deploy time — changing its version should not bust the Lotus/Curio binary cache:CODE_HASH=$(echo "$VERSION_OUTPUT" | grep -E 'default:code:(lotus|curio)' | sha256sum | ...)config.rs— update defaultfilecoin_servicestov1.2.0: Fixes PR CI runs (which use noinit_flags) by ensuring the deployed StateView includes the paginated API the synapse-sdk requires: