Skip to content

chore: first pass of cleanup org-members#38

Open
rjan90 wants to merge 3 commits intomasterfrom
phi/cleanup-members
Open

chore: first pass of cleanup org-members#38
rjan90 wants to merge 3 commits intomasterfrom
phi/cleanup-members

Conversation

@rjan90
Copy link
Copy Markdown
Contributor

@rjan90 rjan90 commented Apr 14, 2026

Summary

A quick first-pass of cleaning up org-members.

What changed

  • Removed stale org-level memberships for users who should no longer be managed as FilOzone org members.
  • Removed related stale repo/team access entries for those users where the cleanup intent was clear.
  • Removed the unused SpaceMeridian team and its repo team grants.
  • Removed unused filecoin-pay-maintainers and filecoin-pin-dev team definitions, since no repositories reference them anymore.
  • Removed redundant direct collaborator grants where existing team access already provides the same permission:
    • TippyFlitsUK on filecoin-cloud, covered by filoz-fs admin access.
    • wjmelements on filecoin-pay, covered by filoz-fs maintain access.
  • Kept direct repo collaborator access where it appears intentionally separate from org membership, since outside/direct collaborators can still be valid even when they are no longer org members.
  • Included the generated config fix updates that re-enabled secret scanning settings for public repositories.

@github-actions
Copy link
Copy Markdown
Contributor

The following access changes will be introduced as a result of applying the plan:

Access Changes
User aarshkshah1992:
  - will leave the organization
  - will lose admin permission to hotvault-demo
  - will lose maintain permission to pdp
  - will lose maintain permission to synapse-sdk
User bajtos:
  - will leave the organization
  - will lose maintain permission to filecoin-pay-auction-bot
  - will lose push permission to filecoin-pay-explorer
  - will lose push permission to filecoin-services
  - will lose push permission to fs-pm
  - will lose push permission to synapse-sdk
  - will lose push permission to tim-docs
User barbaraperic:
  - will lose push permission to filecoin-cloud
  - will lose push permission to filecoin-pay-explorer
  - will lose push permission to synapse-website
User code-pangolin:
  - will leave the organization
User geomatrick:
  - will lose push permission to dealbot
  - will lose push permission to filecoin-cloud
  - will lose maintain permission to filecoin-pay-auction-bot
  - will lose push permission to filecoin-pay-explorer
  - will lose push permission to filecoin-services
  - will lose admin permission to fs-pm
  - will lose push permission to synapse-sdk
  - will lose push permission to tim-docs
  - will leave the organization
User juliangruber:
  - will lose maintain permission to filecoin-pay-auction-bot
  - will lose push permission to filecoin-pay-explorer
  - will lose push permission to filecoin-services
  - will lose push permission to fs-pm
  - will lose push permission to synapse-sdk
  - will lose push permission to tim-docs
User magik6k:
  - will leave the organization
User mirhamasala:
  - will lose admin permission to filecoin-cloud
  - will lose push permission to synapse-website
User pyropy:
  - will leave the organization
  - will lose push permission to filecoin-pay
  - will lose admin permission to filecoin-pay-auction-bot
  - will lose push permission to filecoin-pay-explorer
  - will lose push permission to filecoin-services
  - will lose push permission to fs-pm
  - will lose pull permission to infra
  - will lose push permission to synapse-sdk
  - will lose push permission to tim-docs
User stebalien:
  - will lose maintain permission to pdp
User virajbhartiya:
  - will lose push permission to hotvault-demo
  - will lose push permission to pdp-explorer
User winter-soren:
  - will lose push permission to hotvault-demo
User filoz-fs:
  - will gain admin permission to filecoin-pay-auction-bot
  - will gain admin permission to hotvault-demo

@rjan90 rjan90 requested a review from BigLep April 24, 2026 06:04
@rjan90 rjan90 added this to the M4.2: mainnet GA milestone Apr 24, 2026
@rjan90 rjan90 added this to FOC Apr 24, 2026
@github-project-automation github-project-automation Bot moved this to 📌 Triage in FOC Apr 24, 2026
@rjan90 rjan90 linked an issue Apr 24, 2026 that may be closed by this pull request
@rjan90 rjan90 moved this from 📌 Triage to 🔎 Awaiting review in FOC Apr 24, 2026
rjan90 and others added 3 commits April 24, 2026 08:21
chore: first pass of cleanup
chore: simplify member access config
@rjan90 rjan90 force-pushed the phi/cleanup-members branch from c518432 to d3123b9 Compare April 24, 2026 06:21
@rjan90 rjan90 marked this pull request as ready for review April 24, 2026 06:21
@rjan90
Copy link
Copy Markdown
Contributor Author

rjan90 commented Apr 24, 2026

CI is failing as expected since we need to do the org-membership removals out-of-band, and then clean Terraform state.

Copy link
Copy Markdown
Contributor

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't look to see if there are additional changes that should be made, but I looked to see "is there anything wrong with these changes".

Only other thing I see is Julian losing permissions per #38 (comment)

Feel free to merge/handle after reviewing/incorporating feedback (where makes sense).


I agree we should remove membership for a lot of these folks. We could still list some of them as external collaborators (manual in UI). GitHub magement doesn't support that yet (I have a backlog item for it).

Comment thread github/FilOzone.yml
- longfeiWan9
- nijoe1
- snissn
filecoin-pay-maintainers:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the team since its in https://github.com/search?q=repo%3AFilOzone%2Ffilecoin-pay%20filecoin-pay-maintainers&type=code ?
Maybe add a comment but trim it down?

Comment thread github/FilOzone.yml
- aarshkshah1992
- Kubuxu
- wjmelements
filecoin-pin-dev:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed we can remove

@github-project-automation github-project-automation Bot moved this from 🔎 Awaiting review to ✔️ Approved by reviewer in FOC Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✔️ Approved by reviewer

Development

Successfully merging this pull request may close these issues.

Review org-members before GA

2 participants