Skip to content

feat: add WarmStorageService#topUpCDNPaymentRails - #332

Merged
rvagg merged 5 commits into
nextfrom
add/top-up-cdn-payment-rails
Oct 22, 2025
Merged

feat: add WarmStorageService#topUpCDNPaymentRails#332
rvagg merged 5 commits into
nextfrom
add/top-up-cdn-payment-rails

Conversation

@juliangruber

@juliangruber juliangruber commented Oct 20, 2025

Copy link
Copy Markdown
Member

@github-project-automation github-project-automation Bot moved this to 📌 Triage in FOC Oct 20, 2025
@juliangruber
juliangruber requested review from pyropy and rvagg October 20, 2025 10:03
@juliangruber juliangruber mentioned this pull request Oct 20, 2025
Closed
4 tasks
@rjan90 rjan90 moved this from 📌 Triage to 🔎 Awaiting review in FOC Oct 20, 2025
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 20, 2025 •
edited
Loading

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs		 synapse-dev a3e8c95 Commit Preview URL

Branch Preview URL		 Oct 22 2025, 09:45 AM

@juliangruber

juliangruber commented Oct 20, 2025

Copy link
Copy Markdown
Member Author

not sure why the docs build fails, this should be unrelated. cc @hugomrdias

@rvagg

rvagg commented Oct 20, 2025

Copy link
Copy Markdown
Collaborator

you can ignore docs build failure #329

rvagg
rvagg approved these changes Oct 20, 2025
View reviewed changes

@rvagg rvagg left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, you don't want to provide any additional docs about what this docs or why you would call this? and you don't need any additional validation before the call to avoid footguns?

@github-project-automation github-project-automation Bot moved this from 🔎 Awaiting review to ✔️ Approved by reviewer in FOC Oct 20, 2025
pyropy
pyropy approved these changes Oct 20, 2025
View reviewed changes

@pyropy pyropy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻

Comment thread packages/synapse-sdk/src/warm-storage/service.ts
Comment thread packages/synapse-sdk/src/warm-storage/service.ts Outdated
hugomrdias
hugomrdias requested changes Oct 21, 2025
View reviewed changes
Comment thread packages/synapse-sdk/src/abis/gen.ts
@github-project-automation github-project-automation Bot moved this from ✔️ Approved by reviewer to ⌨️ In Progress in FOC Oct 21, 2025
@juliangruber

juliangruber commented Oct 21, 2025

Copy link
Copy Markdown
Member Author

sure, you don't want to provide any additional docs about what this docs or why you would call this?

I was checking out other methods in this file and also didn't find any docs for it 🤔

and you don't need any additional validation before the call to avoid footguns?

I wouldn't know which

juliangruber and others added 2 commits October 21, 2025 12:19
hugomrdias
hugomrdias requested changes Oct 21, 2025
View reviewed changes
Comment thread packages/synapse-sdk/src/warm-storage/service.ts
@hugomrdias

hugomrdias commented Oct 21, 2025

Copy link
Copy Markdown
Member

can you fix the formatter issues pls

@juliangruber

juliangruber commented Oct 21, 2025

Copy link
Copy Markdown
Member Author

can you fix the formatter issues pls

dc59dd7

@rvagg
rvagg merged commit 309d741 into next Oct 22, 2025
9 of 12 checks passed
@rvagg
rvagg deleted the add/top-up-cdn-payment-rails branch October 22, 2025 12:36
@github-project-automation github-project-automation Bot moved this from ⌨️ In Progress to 🎉 Done in FOC Oct 22, 2025
rvagg pushed a commit that referenced this pull request Oct 22, 2025
@juliangruber @pyropy @rvagg
feat: add WarmStorageService#topUpCDNPaymentRails (#332)
4352b5a 
Co-authored-by: Srdjan <stankovic.srdjo@gmail.com>
rvagg pushed a commit that referenced this pull request Oct 22, 2025
@juliangruber @pyropy @rvagg
feat: add WarmStorageService#topUpCDNPaymentRails (#332)
b128a91 
Co-authored-by: Srdjan <stankovic.srdjo@gmail.com>
rvagg pushed a commit that referenced this pull request Oct 28, 2025
@juliangruber @pyropy @rvagg
feat: add WarmStorageService#topUpCDNPaymentRails (#332)
3a07ed8 
Co-authored-by: Srdjan <stankovic.srdjo@gmail.com>
@github-actions github-actions Bot mentioned this pull request Oct 28, 2025
Merged
@github-actions github-actions Bot mentioned this pull request Feb 26, 2026
Merged
lordshashank pushed a commit to lordshashank/synapse-sdk that referenced this pull request Mar 9, 2026
@juliangruber @pyropy @lordshashank
feat: add WarmStorageService#topUpCDNPaymentRails (FilOzone#332)
151879a 
Co-authored-by: Srdjan <stankovic.srdjo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rvagg rvagg rvagg approved these changes
@pyropy pyropy Awaiting requested review from pyropy
@hugomrdias hugomrdias Awaiting requested review from hugomrdias

Assignees

No one assigned

Labels

None yet

Projects

FOC
Status: 🎉 Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@juliangruber @rvagg @hugomrdias @pyropy @rjan90