fix(core): make streaming upload reachable in Node#776
Merged
Conversation
supportsStreamingFetchBody() probed `new Request('', ...)`, which throws
in Node (no base URL). The catch returned false, so the streaming branch
in uploadPieceStreaming() was unreachable in Node, consumers silently
buffer the full pipeline into a Blob. Use an absolute URL for the probe.
Restructure header construction so Content-Length is only set on the
drain-to-Blob fallback. On streaming bodies length is conveyed via
chunked encoding.
Originally surfaced after investigating a problem reported here:
FilOzone/foc-devnet#103
I haven't reproduced that problem, but it is correct to not set
Content-Length for streaming bodies.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
synapse-dev | ce46a7c | Commit Preview URL Branch Preview URL |
May 07 2026, 12:43 PM |
hugomrdias
approved these changes
May 7, 2026
github-project-automation
Bot
moved this from 🔎 Awaiting review
to ✔️ Approved by reviewer
in FOC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two for the price of one:
supportsStreamingFetchBody() probed
new Request('', ...), which throws in Node (no base URL). The catch returned false, so the streaming branch in uploadPieceStreaming() was unreachable in Node, consumers silently buffer the full pipeline into a Blob. Use an absolute URL for the probe.Restructure header construction so Content-Length is only set on the drain-to-Blob fallback. On streaming bodies length is conveyed via chunked encoding.
Originally surfaced after investigating a problem reported here: FilOzone/foc-devnet#103
I haven't reproduced that problem, but it is correct to not set Content-Length for streaming bodies.