resolveConstFetch iterates NameContext::candidates for constants

[Firehed]

Step 28 of docs/architecture/build-manifest.md.

Done

• hover and definition on X in namespace App; const X = 1; echo X; answer — HoverHandlerTest::testHoverOnNamespacedConstant, DefinitionHandlerTest::testGoToNamespacedConstantDefinition (fixture: tests/Fixtures/src/Resolution/NamespacedConstant.php)
• hover and definition on PHP_INT_MAX in a namespaced file with no use const answer — the global-fallback path is exercised through FIXTURE_HELPER_DEFINED (a userland global constant with a source location, so definition can assert a target): HoverHandlerTest::testHoverOnGlobalConstantFromNamespacedFile, DefinitionHandlerTest::testGoToGlobalConstantDefinitionFromNamespacedFile
• resolveConstFetch has no direct lookupConstant call that bypasses the candidate loop — enforced by disallowedMethodCalls in phpstan.neon (allowlist restricted to src/Resolution/ExpressionResolver.php plus the composite delegation site)
• a test covers both the namespaced-constant and global-fallback paths — the four tests above

Tightening

Beyond the row's spec, made ScopeFinder::resolveName private. It had one remaining src/ caller (resolveClassName, which now inlines the resolved-name attribute read). This shuts the door on future non-class name resolution bypassing NameContext by going through the raw resolvedName attribute.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.39%. Comparing base (01bc5be) to head (58e4b25).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff            @@
##               main     #486   +/-   ##
=========================================
  Coverage     99.39%   99.39%           
- Complexity     1864     1865    +1     
=========================================
  Files           133      133           
  Lines          4785     4788    +3     
=========================================
+ Hits           4756     4759    +3     
  Misses           29       29           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.