Merged
Conversation
Route docblock access through the ResolvedSymbol interface method instead of the raw ->docblock field and DocblockParser::extractDescription. A future normalisation of getDocumentation (e.g. tag stripping) reaches completion detail the same way it reaches hover. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Documentation for user-defined functions now carries the raw docblock, matching hover's step-25 pattern. The step-30 presenter will strip tags for both surfaces uniformly. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The extractDescription entry drained (SymbolCandidates no longer calls it). The new getDocumentation entry is step-30 territory: the presenter will absorb this and the other getDocumentation callers together. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #487 +/- ##
============================================
- Coverage 99.39% 99.39% -0.01%
+ Complexity 1865 1862 -3
============================================
Files 133 133
Lines 4788 4783 -5
============================================
- Hits 4759 4754 -5
Misses 29 29 ☔ View full report in Codecov by Harness. |
Step-29 temporarily regresses the completion-detail output from extracted description to raw docblock (see the function-surface parity golden update on this branch). Extend step-30 to name the fix so the regression is scheduled, not implicit: the presenter owns docblock text preparation, and its Done clause pins the golden's `documentation` fields back to extracted descriptions. Notes that `getDocumentation()` must keep returning the raw docblock so `ExpressionResolver`'s foreach element-type inference (which reads `@var`) keeps working, so extraction lives at the presenter, not in `HasSymbolLocation`.
Firehed
marked this pull request as ready for review
September 3, 2026 18:19
Owner
Author
|
Needs step 30 to land first to hit the exactly-described acceptance criteria; instead, taking the baseline trade and fast-following in the next step. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
step-29 acceptance
SymbolCandidatesdoes not name->docblockorDocblockParserdirectly. Proof:grep -n 'docblock\|DocblockParser' src/Completion/SymbolCandidates.phpreturns nothing; PHPStandisallowedMethodCallsforDocblockParser::extractDescription(already scoped toHasSymbolLocation.php) drains the baseline entry that pointed at this file.getDocumentation()(e.g. tag stripping) reaches completion detail the same way it reaches hover. Proof:SymbolCandidates::functionDetailcalls$info->getDocumentation()— the same interface methodExpressionResolverreads (step-25) and the same one the step-30 presenter will normalise once for every surface.Notes
ResolvedSymbol::getDocumentation()returns the raw docblock text. Completiondocumentationfor user-defined functions now carries/** ... */markers, matching hover's step-25 behaviour. Thefunction-surfaceparity golden is recaptured to freeze that.SymbolCandidates.phpflips from theextractDescriptionban to thegetDocumentationban; step-30 (presenter) will absorb this and the othergetDocumentationcallers together. Total baseline count unchanged (5 → 5).🤖 Written by AI, reviewed by human.