-
Notifications
You must be signed in to change notification settings - Fork 4.5k
fix(workflows): create the main spec when a capability is new #1701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
clay-good
wants to merge
7
commits into
Fission-AI:main
Choose a base branch
from
clay-good:claude/openspec-issue-fixes-ae3397
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9f3dc0c
fix(workflows): create the main spec when a capability is new
clay-good f55ba15
fix(sync): never create a main spec with nothing to put in it
clay-good cce935b
docs: define "main spec" and close the no-ADDED archive loop
clay-good e3577c3
docs(glossary): a standalone sync creates the main spec too
clay-good 570fe27
Merge remote-tracking branch 'origin/main' into claude/openspec-issue…
clay-good b3c7046
Merge remote-tracking branch 'origin/main' into claude/openspec-issue…
clay-good da4d4c8
fix(workflows): clarify removed deltas for missing specs
clay-good File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@fission-ai/openspec": patch | ||
| --- | ||
|
|
||
| Agent-driven archive and sync workflows now create a missing main spec from `ADDED` requirements instead of treating it as already synced. They stop rather than inventing `MODIFIED` or `RENAMED` requirements or writing an empty spec for a `REMOVED`-only delta. Fixes #1222 and #1264. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -75,12 +75,26 @@ | |
| - **AND** copy the delta's `## Purpose` body into it when the delta has one, matching what `openspec archive` does | ||
| - **AND** write a brief TBD placeholder Purpose only when the delta has none | ||
|
|
||
| #### Scenario: MODIFIED or RENAMED against a capability with no main spec | ||
| - **WHEN** delta contains `## MODIFIED Requirements` or `## RENAMED Requirements` | ||
| - **AND** the capability has no main spec yet | ||
| - **THEN** stop the sync for that capability and report that only ADDED requirements are allowed for a new spec, matching what `openspec archive` does | ||
| - **AND** never invent the missing requirement | ||
| - **AND** skip any `## REMOVED Requirements` with a warning, since there is nothing to remove | ||
|
|
||
| #### Scenario: Nothing to put in a new spec | ||
| - **WHEN** a delta targets a capability with no main spec | ||
| - **AND** the delta has no `## ADDED Requirements` to seed it with | ||
| - **THEN** create no main spec and leave the specs directory untouched | ||
| - **AND** report it, matching `openspec archive`, which aborts the same case with `Spec must have at least one requirement` | ||
| - **AND** never write an empty `## Requirements` section | ||
|
|
||
| #### Scenario: Merged main spec keeps canonical structure | ||
| - **WHEN** the agent writes a main spec during sync | ||
| - **THEN** every requirement lives under a single `## Requirements` section | ||
| - **AND** the main spec contains no delta operation headers (`## ADDED/MODIFIED/REMOVED/RENAMED Requirements`) | ||
|
|
||
| ### Requirement: Skill Output | ||
|
Check warning on line 97 in openspec/specs/specs-sync-skill/spec.md
|
||
| The skill SHALL provide clear feedback on what was applied. | ||
|
|
||
| #### Scenario: Show applied changes | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.