fix(explore): require explicit confirmation before writing files - #1716
fix(explore): require explicit confirmation before writing files#1716aymanxdev wants to merge 4 commits into
Conversation
Fork pull request not scannedFork pull requests are not scanned. Open the branch in this repository, then create a new pull request. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughExplore mode now distinguishes read-only actions from write-capable actions. Write-capable actions require named files or artifacts and separate, scope-limited confirmation. Tests cover the updated templates and generated skill content. ChangesExplore write policy
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized wording change adds explicit confirmation before explore writes files without changing other workflow capabilities. No actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Status
LGTM. The write-confirmation contract is scope-bound, generated output is in parity, and CI is green.
What was wrong
Explore allowed OpenSpec artifacts “if the user asks,” which could let an agent mistake answers to its own design questions for consent to write. Workflow configuration such as schemas, templates, and
openspec/config.yamlwas also not clearly classified as implementation work.How it was fixed
Both Explore delivery surfaces now:
The committed
openspec-exploreskill was regenerated from the source template and parity hashes were refreshed.Replication / proof
Notes / nits
This changes prompt behavior only. It does not alter CLI write paths or grant Explore permission to implement application code.
Closes #1715