[emyller]

Closes SDK-12.

Set up CodSpeed in GitHub Actions.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 6f92fe5c-f385-432d-a389-22969f683a19

Commits

Reviewing files that changed from the base of the PR and between 5094b76 and d2116b8.

Files selected for processing: 5

• .gitmodules
• Makefile
• pom.xml
• src/jmh/java/com/flagsmith/SdkBenchmark.java
• third-party/sdk-benchmarks

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

Adds JMH benchmarks for SDK evaluation against small, medium, and large environment documents. Adds Maven and Make configuration to package and run the benchmarks as an executable JAR. Adds submodule references for benchmark code and environment data. Adds a CodSpeed workflow that runs the benchmark target on pushes to main, pull requests, and manual dispatches.

Priority: Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: Minimal · up to d2116

The benchmark setup is ready for normal validation; no actionable merge-blocking risk remains in the reviewed changes.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

---

Review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 63da0de6-e205-4713-a49b-2896243631ce

Commits

Reviewing files that changed from the base of the PR and between 773fb3e and e6768c5.

Files selected for processing: 5

• .github/workflows/codspeed.yml
• .gitmodules
• pom.xml
• src/jmh/java/com/flagsmith/flagengine/EngineBenchmark.java
• third-party/codspeed-jvm

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

[codspeed]

Congrats! CodSpeed is installed 🎉

🆕 15 new benchmarks were detected.

You will start to see performance impacts in the reports once the benchmarks are run from your default branch.

Detected benchmarks

• getEnvironmentFlags[large]: 1.3 ms
• getEnvironmentFlags[medium]: 303.9 µs
• getEnvironmentFlags[small]: 9.8 µs
• getIdentityFlagsNoTraits[large]: 2.5 s
• getIdentityFlagsNoTraits[medium]: 42.5 ms
• getIdentityFlagsNoTraits[small]: 2.1 ms
• getIdentityFlagsWithIdentityOverrides[large]: 2.5 s
• getIdentityFlagsWithIdentityOverrides[medium]: 41.8 ms
• getIdentityFlagsWithIdentityOverrides[small]: 2.1 ms
• getIdentityFlagsWithTraits[large]: 2.5 s
• getIdentityFlagsWithTraits[medium]: 43.5 ms
• getIdentityFlagsWithTraits[small]: 2.5 ms
• getIdentitySegmentsWithTraits[large]: 2.4 s
• getIdentitySegmentsWithTraits[medium]: 43.2 ms
• getIdentitySegmentsWithTraits[small]: 2.5 ms

---

[khvn26]

CI harness looks good. Questions for the benchmark itself.

[coderabbitai]

Actionable comments posted: 1

---

Review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: d4ad6709-8ce7-44ac-987d-2222537a71b8

Commits

Reviewing files that changed from the base of the PR and between e6768c5 and 5094b76.

Files selected for processing: 7

• .github/workflows/codspeed.yml
• Makefile
• pom.xml
• src/jmh/java/com/flagsmith/SDKBenchmark.java
• src/jmh/resources/environments/large.json
• src/jmh/resources/environments/medium.json
• src/jmh/resources/environments/small.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

[khvn26]

Much better now! I think we can do away without one of the benchmarks, the rest look excellent to me.