feat(Feature Versioning): add multi variate capabilities to the experimental update-flag endpoints by emyller · Pull Request #7955 · Flagsmith/flagsmith

emyller · 2026-07-06T23:52:16Z

Thanks for submitting a PR! Please check the boxes below:

I have read the Contributing Guide.
I have added information to docs/ if required so people know about the feature.
I have filled in the "Changes" section below.
I have filled in the "How did you test this code" section below.

Changes

Contributes to #7642

Refactors update-flag code for better typing and maintenance.
Introduces MV (multi variate) support for both experimental update-flags endpoints.
Behaviour is consistent to UX in the dashboard.
Makes a few properties optional, to allow for isolated changes to MVs — and other properties too, why not.

How did you test this code?

Unit tests.

How to review

4/5 raw effort.

3/5 if read commit-by-commit. Each is concern-isolated, and stack nicely.

vercel · 2026-07-06T23:52:22Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
docs	Ready	Preview, Comment	Jul 10, 2026 6:56pm

2 Skipped Deployments

Project	Deployment	Actions	Updated (UTC)
flagsmith-frontend-preview	Ignored	Preview	Jul 10, 2026 6:56pm
flagsmith-frontend-staging	Ignored	Preview	Jul 10, 2026 6:56pm

coderabbitai · 2026-07-06T23:52:25Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: b3b64a6d-eef2-4b95-830f-32d696beeff2

📥 Commits

Reviewing files that changed from the base of the PR and between 42ea717 and 656a5ca.

📒 Files selected for processing (2)

api/features/models.py
docs/docs/integrating-with-flagsmith/flagsmith-api-overview/admin-api/updating-flags.md

📝 Walkthrough

Walkthrough

This pull request renames the update-flag endpoints, serializers, and services to Option A and Option B. It adds typed payload schemas and change-set dataclasses for feature values, multivariate options, and segment overrides. Versioning now uses shared helpers for feature-state and multivariate updates. Rollout code, routing, views, tests, OpenAPI schemas, and documentation are updated.

Estimated code review effort: 4 (Complex) | ~60 minutes

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-07-08T23:26:24Z

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

6 passed

Details

6 tests across 4 suites
40.7 seconds
8c25092
🔄 Run: #18118 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

3 passed

Details

3 tests across 3 suites
41.5 seconds
8c25092
🔄 Run: #18118 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

4 passed

Details

4 tests across 3 suites
38 seconds
8c25092
🔄 Run: #18118 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

7 passed

Details

7 tests across 6 suites
35 seconds
8c25092
🔄 Run: #18118 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

4 passed

Details

4 tests across 3 suites
42.8 seconds
9d8dc5c
🔄 Run: #18142 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

4 passed

Details

4 tests across 3 suites
45.4 seconds
9d8dc5c
🔄 Run: #18142 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

5 passed

Details

5 tests across 4 suites
34.1 seconds
9d8dc5c
🔄 Run: #18142 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

4 passed

Details

4 tests across 2 suites
11.7 seconds
9d8dc5c
🔄 Run: #18142 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

4 passed

Details

4 tests across 3 suites
34.3 seconds
42ea717
🔄 Run: #18170 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

4 passed

Details

4 tests across 3 suites
36.7 seconds
42ea717
🔄 Run: #18170 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

4 passed

Details

4 tests across 3 suites
37.7 seconds
42ea717
🔄 Run: #18170 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

1 passed

Details

1 test across 1 suite
53.9 seconds
42ea717
🔄 Run: #18170 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

5 passed

Details

5 tests across 3 suites
12.1 seconds
656a5ca
🔄 Run: #18171 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

2 passed

Details

2 tests across 2 suites
41 seconds
656a5ca
🔄 Run: #18171 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

6 passed

Details

6 tests across 4 suites
12.1 seconds
656a5ca
🔄 Run: #18171 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

1 passed

Details

1 test across 1 suite
59.5 seconds
656a5ca
🔄 Run: #18171 (attempt 1)

github-actions · 2026-07-08T23:27:17Z

Visual Regression

19 screenshots compared. See report for details.
View full report

coderabbitai

Actionable comments posted: 5

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

api/features/feature_states/serializers.py (1)
238-254: 🚀 Performance & Scalability | 🔵 Trivial | ⚡ Quick win

N+1 query in validate_segment_overrides.

One Segment.objects.filter(...).exists() query per segment override via validate_segment_id. Already flagged with a TODO — worth batching into a single filter(id__in=segment_ids, project_id=...).count() check once out of experimentation, as noted.
♻️ Possible batched check
-        for segment_id in segment_ids:
-            self.validate_segment_id(segment_id)
+        valid_count = Segment.objects.filter(
+            id__in=segment_ids, project_id=_environment(self.context).project_id
+        ).count()
+        if valid_count != len(segment_ids):
+            raise serializers.ValidationError(
+                "One or more segments not found in project"
+            )
Happy to open this as a follow-up if useful.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 39f7d2ea-874a-4876-9a95-d80d6825179b

📥 Commits

Reviewing files that changed from the base of the PR and between a7b0d21 and 8c25092.

📒 Files selected for processing (18)

api/api/urls/experiments.py
api/experimentation/services.py
api/features/feature_states/serializers.py
api/features/feature_states/types.py
api/features/feature_states/views.py
api/features/versioning/dataclasses.py
api/features/versioning/versioning_service.py
api/tests/integration/conftest.py
api/tests/integration/environments/identities/test_integration_identities.py
api/tests/integration/features/versioning/test_update_flag_endpoints.py
api/tests/integration/helpers.py
api/tests/unit/features/feature_states/test_serializers.py
api/tests/unit/features/feature_states/test_unit_feature_states_views.py
api/tests/unit/features/versioning/test_unit_versioning_versioning_service.py
docs/docs/deployment-self-hosting/observability/_events-catalogue.md
docs/docs/integrating-with-flagsmith/flagsmith-api-overview/admin-api/updating-flags.md
mcp/src/flagsmith_mcp/openapi.json
openapi.yaml

Zaimwa9 · 2026-07-09T07:17:58Z

+        return attrs
+

+class UpdateFlagOptionASerializer(BaseFeatureUpdateSerializer[FeatureState]):


Option A and Option B are becoming the new semantic for v1 and v2 ?

To the public, they already are. The refactor here happens for:

Eliminate ambiguity, i.e. flag-update v1/v2 over feature versioning v1/v2.

Make it consistent with user docs.

Improve clarity of naming of the backend components.

👻
Only certain spirits are expected to have different names depending on the realm they're in, but these are just code.

Ah ok, I didn't have context over the public documentation. Makes sense, thanks for the clarification. I thought on the opposite this changes were a specific case of renaming versioning v1 versus v2.

Just a NIT then if I may:
It looks like this example of the doc is missing the second request in Option A

If my understanding is correct, the override should be updated in a separate request. If my understanding is wrong please ignore 👍

Feel free to resolve this thread

Thanks. Option A here is indeed one request, but the docs make it confusing. I've improved things with 42ea717 — also getting rid of the "highest=1" slop.

Please note these are unrelated to the scope of the PR, though I think the improvement warrants piggybacking.

coderabbitai

Actionable comments posted: 2

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 7ed23c6d-926a-4bdb-9501-ab0991c865b6

📥 Commits

Reviewing files that changed from the base of the PR and between 8c25092 and 9d8dc5c.

📒 Files selected for processing (18)

api/api/urls/experiments.py
api/experimentation/services.py
api/features/feature_states/serializers.py
api/features/feature_states/types.py
api/features/feature_states/views.py
api/features/versioning/dataclasses.py
api/features/versioning/versioning_service.py
api/tests/integration/conftest.py
api/tests/integration/environments/identities/test_integration_identities.py
api/tests/integration/features/versioning/test_update_flag_endpoints.py
api/tests/integration/helpers.py
api/tests/unit/features/feature_states/test_serializers.py
api/tests/unit/features/feature_states/test_unit_feature_states_views.py
api/tests/unit/features/versioning/test_unit_versioning_versioning_service.py
docs/docs/deployment-self-hosting/observability/_events-catalogue.md
docs/docs/integrating-with-flagsmith/flagsmith-api-overview/admin-api/updating-flags.md
mcp/src/flagsmith_mcp/openapi.json
openapi.yaml

coderabbitai

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

docs/docs/integrating-with-flagsmith/flagsmith-api-overview/admin-api/updating-flags.md (1)

235-238: 🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win

Clarify multivariate_options omission semantics.
State that omitting the field leaves existing options unchanged, while providing the array replaces the current set and deletes any omitted options.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: f88b0d43-16e9-4175-9878-67217361caf2

📥 Commits

Reviewing files that changed from the base of the PR and between 9d8dc5c and 42ea717.

📒 Files selected for processing (7)

api/features/feature_states/serializers.py
api/features/feature_states/types.py
api/features/models.py
api/features/versioning/dataclasses.py
api/features/versioning/versioning_service.py
api/tests/integration/features/versioning/test_update_flag_endpoints.py
docs/docs/integrating-with-flagsmith/flagsmith-api-overview/admin-api/updating-flags.md

emyller self-assigned this Jul 6, 2026

github-actions Bot added api Issue related to the REST API docs Documentation updates feature New feature or request and removed docs Documentation updates labels Jul 6, 2026

emyller force-pushed the feat/multivariate-update-flag-endpoints branch from 420e419 to d64e257 Compare July 7, 2026 01:00

vercel Bot deployed to Preview – docs July 7, 2026 01:01 View deployment

github-actions Bot added docs Documentation updates feature New feature or request and removed feature New feature or request docs Documentation updates labels Jul 7, 2026

khvn26 reviewed Jul 7, 2026

View reviewed changes

Comment thread api/tests/integration/conftest.py

emyller force-pushed the feat/multivariate-update-flag-endpoints branch from d64e257 to 23e4464 Compare July 8, 2026 02:33

github-actions Bot added the docs Documentation updates label Jul 8, 2026

vercel Bot deployed to Preview – docs July 8, 2026 02:34 View deployment

github-actions Bot added feature New feature or request docs Documentation updates and removed feature New feature or request docs Documentation updates labels Jul 8, 2026

vercel Bot deployed to Preview – docs July 8, 2026 21:24 View deployment

github-actions Bot added the docs Documentation updates label Jul 8, 2026

vercel Bot deployed to Preview – docs July 8, 2026 21:28 View deployment

vercel Bot deployed to Preview – flagsmith-frontend-staging July 8, 2026 21:28 View deployment

vercel Bot deployed to Preview – flagsmith-frontend-preview July 8, 2026 21:28 View deployment

github-actions Bot removed the feature New feature or request label Jul 8, 2026

coderabbitai Bot reviewed Jul 8, 2026

View reviewed changes

Zaimwa9 reviewed Jul 9, 2026

View reviewed changes

emyller marked this pull request as draft July 9, 2026 15:00

github-actions Bot added docs Documentation updates feature New feature or request and removed feature New feature or request docs Documentation updates labels Jul 10, 2026

emyller added 12 commits July 9, 2026 22:25

red stuff

f8a93b0

update docs

87d891d

improve types

14f0d8c

allow for partial updates

66cc87a

oops

314787e

green stuff

b936f14

make sync

15ba926

oh snap it was no slop

6f4513e

improve tests

78712a3

⚛️

9f4b4db

explicitly drop value

7003087

late band member

9d8dc5c

emyller force-pushed the feat/multivariate-update-flag-endpoints branch from c4e9676 to 9d8dc5c Compare July 10, 2026 01:35

github-actions Bot added docs Documentation updates feature New feature or request and removed feature New feature or request docs Documentation updates labels Jul 10, 2026

coderabbitai Bot reviewed Jul 10, 2026

View reviewed changes

Comment thread api/tests/integration/features/versioning/test_update_flag_endpoints.py

Comment thread api/tests/integration/features/versioning/test_update_flag_endpoints.py

better naming and text for humans

8a27366

coderabbitai Bot reviewed Jul 10, 2026

View reviewed changes

improve docs

656a5ca

		return attrs


		class UpdateFlagOptionASerializer(BaseFeatureUpdateSerializer[FeatureState]):

Uh oh!

Conversation

emyller commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

How did you test this code?

How to review

Uh oh!

vercel Bot commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Uh oh!

Uh oh!

github-actions Bot commented Jul 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Uh oh!

github-actions Bot commented Jul 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Visual Regression

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Zaimwa9 Jul 9, 2026

Choose a reason for hiding this comment

Uh oh!

emyller Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Zaimwa9 Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

emyller Jul 10, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

emyller commented Jul 6, 2026 •

edited

Loading

vercel Bot commented Jul 6, 2026 •

edited

Loading

coderabbitai Bot commented Jul 6, 2026 •

edited

Loading

github-actions Bot commented Jul 8, 2026 •

edited

Loading

github-actions Bot commented Jul 8, 2026 •

edited

Loading

emyller Jul 9, 2026 •

edited

Loading

Zaimwa9 Jul 10, 2026 •

edited

Loading