Skip to content

fix(Experiments): Dark mode visibility in results page #7980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Zaimwa9 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(Experiments): Dark mode visibility in results page #7980

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/web/components/experiments/results/ExperimentConfiguration.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const ExperimentConfiguration: FC<ExperimentConfigurationProps> = ({
<div className='col-md-4'>
<ContentCard compact title='Feature flag'>
<div>
<span className='selectable-card__tag'>
<span className='experiment-results__tag'>
{experiment.feature.name}
</span>
</div>
Expand All @@ -40,7 +40,7 @@ const ExperimentConfiguration: FC<ExperimentConfigurationProps> = ({
<div>
<div>{metric.metric_name}</div>
<div className='mt-3'>
<span className='selectable-card__tag'>
<span className='experiment-results__tag'>
{EXPECTED_DIRECTION_CHIP[metric.expected_direction]}
</span>
</div>
Expand Down
6 changes: 3 additions & 3 deletions frontend/web/components/experiments/results/ExperimentDetailHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ const ExperimentDetailHeader: FC<ExperimentDetailHeaderProps> = ({
if (isEditingHypothesis) {
return (
<div className='mt-3' style={{ maxWidth: 640 }}>
<span className='fs-caption text-muted fw-bold'>Hypothesis</span>
<span className='fs-caption text-secondary fw-bold'>Hypothesis</span>
<div className='d-flex align-items-start gap-2 mt-1'>
<textarea
autoFocus
Expand Down Expand Up @@ -252,9 +252,9 @@ const ExperimentDetailHeader: FC<ExperimentDetailHeaderProps> = ({

return (
<div className='mt-3' style={{ maxWidth: 640 }}>
<span className='fs-caption text-muted fw-bold'>Hypothesis</span>
<span className='fs-caption text-secondary fw-bold'>Hypothesis</span>
<div className='d-flex align-items-start gap-1'>
<p className='text-muted mb-0'>
<p className='text-secondary mb-0'>
Comment thread
talissoncosta marked this conversation as resolved.
{experiment.hypothesis || (
<span className='fst-italic'>No hypothesis</span>
)}
Expand Down
6 changes: 3 additions & 3 deletions frontend/web/components/experiments/results/ExperimentResultsScorecardTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,10 @@ const renderLift = (
liftRange: number,
): ReactNode => {
if (identity.isControl) {
return <span className='text-muted fs-caption'>Baseline</span>
return <span className='text-secondary fs-caption'>Baseline</span>
}
if (!inference) {
return <span className='text-muted fs-caption'>Collecting data…</span>
return <span className='text-secondary fs-caption'>Collecting data…</span>
}
const colour = getLiftColour(inference.lift, direction)
const left = liftToPercent(inference.ci_low, liftRange)
Expand Down Expand Up @@ -94,7 +94,7 @@ const renderCI = (
inference: Inference | null,
): ReactNode => {
if (identity.isControl) {
return <span className='text-muted fs-caption'>Baseline</span>
return <span className='text-secondary fs-caption'>Baseline</span>
}
if (!inference) return '—'
return (
Expand Down
4 changes: 2 additions & 2 deletions frontend/web/components/experiments/results/StatCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ type StatCardProps = {

const StatCard: FC<StatCardProps> = ({ label, loading, value }) => (
<ContentCard compact>
<div className='text-muted fs-caption'>{label}</div>
<div className='text-secondary fs-caption'>{label}</div>
<div className='fs-3 mt-1'>
{loading ? <span className='text-muted'>—</span> : value ?? '—'}
{loading ? <span className='text-secondary'>—</span> : value ?? '—'}
</div>
</ContentCard>
)
Expand Down
11 changes: 11 additions & 0 deletions frontend/web/components/experiments/results/results.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,17 @@

.experiment-recommendation {
font-size: 16px;
color: var(--color-text-default);
}

.experiment-results__tag {
display: inline-block;
font-size: 12px;
font-weight: var(--font-weight-regular);
padding: 2px 8px;
border-radius: var(--radius-sm);
background: var(--color-surface-emphasis);
color: var(--color-text-secondary);
}

.experiment-results {
Expand Down
Loading