fix(dark mode): reclaim border-colour and shadow utilities for tokens#7986
fix(dark mode): reclaim border-colour and shadow utilities for tokens#7986talissoncosta wants to merge 1 commit into
Conversation
Extend the Bootstrap utilities map-remove beyond text colour: - border-color danger/info/success/warning -> token .border-* (values are identical to Bootstrap, so a no-op; ownership only). - shadow sm/lg/none -> token .shadow-* so the DS shadow scale is consistent. .shadow-md/.shadow-xl were already token-only; .shadow-sm/.shadow-lg were silently using Bootstrap's heavier shadows. Suffixless .shadow stays Bootstrap. Contributes to #6606 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Bootstrap stylesheet now removes the Estimated code review effort: 2 (Simple) | ~5 minutes Comment |
Docker builds report
|
|
Consolidated into #7982 so the whole dark-mode colour change can be QA'd in one pass. Same commit is included there. |
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
Failed testsfirefox › tests/environment-permission-test.pw.ts › Environment Permission Tests › Environment-level permissions control access to features, identities, and segments @enterprise |
Visual Regression19 screenshots compared. See report for details. |
Changes
Contributes to #6606. Same
map-removepattern as the text-colour reclaim, extended to two more utility families found by auditing token-vs-Bootstrap collisions.danger/info/success/warning): token.border-*was shadowed by Bootstrap. Values are identical, so this is a no-op; it just moves ownership to the token layer.sm/lg/none):.shadow-smand.shadow-lgwere silently using Bootstrap's shadows, while.shadow-md/.shadow-xl(token-only) used the DS tokens, so the scale was half-and-half. Now all of sm/md/lg/xl use--shadow-*. Suffixless.shadowstays Bootstrap.How did you test this code?
Compiled the stylesheet:
.border-*now resolve tovar(--color-border-*), and.shadow-sm/.shadow-lgtovar(--shadow-*). Border is a no-op (identical values). Shadow is a real change but tiny footprint (shadow-sm: 1 usage,shadow-lg: 0) — the DS shadows are subtler; worth a quick eyeball on that oneshadow-smelement.