fix(dark mode): stop .text-info being hijacked to purple#7987
fix(dark mode): stop .text-info being hijacked to purple#7987talissoncosta wants to merge 1 commit into
Conversation
An unscoped `.text-info { color: $primary !important }` in _alert.scss
(added in 2022 for two webhook doc links) forced every .text-info to
purple globally, overriding the info-blue token. Move those two links to
.text-action (the correct interactive/link colour) and remove the override,
so .text-info resolves to --color-text-info again.
Contributes to #6606
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
github-actions
Bot
added
the
front-end
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughUpdated the Secret help links in the audit-log webhook and webhook creation modals to use the Estimated code review effort: 1 (Trivial) | ~2 minutes Comment |
Docker builds report
|
|
Consolidated into #7982 so the whole dark-mode colour change can be QA'd in one pass. Same commit is included there. |
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
|
Visual Regression19 screenshots compared. See report for details. |
1 participant
Changes
Contributes to #6606.
_alert.scsshad an unscoped.text-info { color: $primary !important }(added in 2022 for two webhook secret-field doc links). It forced every.text-infoto purple globally, overriding the info-blue token, and!importantmeant it survived the text-colour reclaim too.CreateWebhook,CreateAuditLogWebhook) to.text-action— they're links, so the interactive/purple colour is the correct semantic, and appearance is preserved..text-inforesolves to--color-text-info(info-blue) again.How did you test this code?
Compiled the stylesheet: the purple
.text-inforule is gone;.text-infonow resolves to the info-blue token. Notext-infoclassNames remain (both moved totext-action). The two links keep their purple.