ci(renovate): fix lock file maintenance author, schedule and scope - #8516
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe Renovate configuration now ignores commits from Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The Renovate configuration has no established merge-blocking defect. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Docker builds report
|
✅ private-cloud · depot-ubuntu-latest-16 — run #20441 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
🗂️ Previous results✅ private-cloud · depot-ubuntu-latest-arm-16 — run #20441 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
✅ oss · depot-ubuntu-latest-arm-16 — run #20441 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
✅ oss · depot-ubuntu-latest-16 — run #20441 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #20440 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
✅ oss · depot-ubuntu-latest-arm-16 — run #20440 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
✅ private-cloud · depot-ubuntu-latest-16 — run #20438 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
✅ private-cloud · depot-ubuntu-latest-16 — run #20440 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
✅ oss · depot-ubuntu-latest-16 — run #20440 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #20438 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
✅ private-cloud · depot-ubuntu-latest-16 — run #20439 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
✅ oss · depot-ubuntu-latest-arm-16 — run #20439 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
|
Visual Regression19 screenshots compared. See report for details. |
github-actions
Bot
added
ci-cd
Renovate commits as the flagsmith-engineering GitHub App (216534828+flagsmith-engineering[bot]@users.noreply.github.com), but RENOVATE_GIT_AUTHOR was set to a noreply address carrying user ID 1414362, which belongs to an unrelated account. isBranchModified() strips gitAuthorEmail from the set of authors seen on a branch and treats anything left over as a human edit, so every branch Renovate created looked externally modified on the next run. That silently blocked all rebases and left PR-less branches permanently stuck. The variable itself is fixed in repo settings. This adds gitIgnoredAuthors so the docs-artefacts workflow, which pushes to Renovate branches under a third address, does not reintroduce the same false positive. Also widens the lock file maintenance window. GitHub delays the 03:00 UTC cron by 18-22 minutes, leaving under 40 minutes of headroom against a 4am cutoff, and a miss costs a full week. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
9656c23 to
e7f04dd
Compare
github-actions
Bot
added
ci-cd
e7f04dd to
6890946
Compare
github-actions
Bot
added
ci-cd
One lock file maintenance branch covers api, docs, frontend and mcp, but semanticCommitScope is a scalar taken from whichever upgrade sorts first, so the PR came out titled deps(mcp) while touching all four. Moving the rule last and clearing the scope gives "deps: Lock file maintenance". It has to be last because packageRules are applied again after the updateType config (flatten.ts), so from its old position the per-path rules below re-applied and won.
6890946 to
f6354ff
Compare
matthewelwell
changed the title
github-actions
Bot
added
ci-cd
github-actions
Bot
added
ci-cd
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 77073941-9ace-45b8-8ed9-bc304e07724f
📒 Files selected for processing (1)
renovate.json
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.
2 participants
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Contributes to #7697
Three fixes to lock file maintenance:
gitIgnoredAuthors— our docs-artefacts workflow pushes to Renovate branches under its own address, which makes Renovate treat those branches as hand-edited and refuse to touch them again. (The relatedRENOVATE_GIT_AUTHORvariable had the app ID where the bot user ID should be; already fixed in repo settings.)before 4am→before 9am. GitHub delays the 03:00 cron by ~20 minutes, so we had under 40 minutes of headroom and a miss costs a full week.deps(mcp)while touching api, docs, frontend and mcp. Nowdeps: Lock file maintenance.How did you test this code?
renovate-config-validatorpasses. ThegitAuthorfix is confirmed working — with it in place Renovate rebasedrenovate/lock-file-maintenanceinstead of skipping it as edited.The scope rule has to sit last in
packageRules:packageRulesare applied again after the updateType config, so from anywhere earlier the per-path rules re-apply and win.🤖 Generated with Claude Code