fix(integrations): fix Slack integration modal after redirect - #8542
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
📝 WalkthroughWalkthrough
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Severity of issue fixed: Medium Merge Risk: 🟡 Moderate · up to Users can submit a Slack channel from the wrong environment, so the environment should be locked or channel state refreshed before merge. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Docker builds report
|
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #20489 (attempt 2)Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
🗂️ Previous results❌ private-cloud · depot-ubuntu-latest-arm-16 — run #20489 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
Failed testsfirefox › tests/environment-permission-test.pw.ts › Environment Permission Tests › Environment-level permissions control access to features, identities, and segments @enterprise ✅ private-cloud · depot-ubuntu-latest-16 — run #20489 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
✅ oss · depot-ubuntu-latest-16 — run #20489 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-16)Details
✅ oss · depot-ubuntu-latest-arm-16 — run #20489 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
|
Visual Regression19 screenshots compared. See report for details. |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 79e64a3d-35c0-4de5-a3a0-b71c0ba0d26e
📒 Files selected for processing (2)
frontend/web/components/IntegrationList.tsxfrontend/web/components/modals/CreateEditIntegrationModal.tsx
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.
Zaimwa9
left a comment
There was a problem hiding this comment.
Just one props to remove otherwise lgtm
Zaimwa9
left a comment
There was a problem hiding this comment.
happy to approve, thanks for looking into this
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Closes #8359
Fixed the modal showing the project picker instead of channel picker after Slack redirect.
How did you test this code?
Tested it manually, and disable changing the project after the Slack redirect since you can only connect to projects you approved.