Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
github-actions
Bot
added
api
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe change adds authenticated endpoints to list a feature’s dependencies and dependents within an environment. It adds response types and API schemas for dependency edges and referencing segments. The live override query now excludes scheduled overrides by default and can include them when requested. Existing segment consumers and dependency services use the updated query. Tests cover listing results, override state, environment scope, missing resources, and permissions. Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to The dependency-listing endpoints appear ready to merge after normal checks; no outstanding issue has been established. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Docker builds report
|
github-actions
Bot
added
feature
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #20818 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
🗂️ Previous results✅ private-cloud · depot-ubuntu-latest-16 — run #20818 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
✅ oss · depot-ubuntu-latest-arm-16 — run #20818 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
✅ oss · depot-ubuntu-latest-16 — run #20818 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #20705 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
✅ private-cloud · depot-ubuntu-latest-16 — run #20705 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
✅ oss · depot-ubuntu-latest-arm-16 — run #20705 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
✅ oss · depot-ubuntu-latest-16 — run #20705 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #20621 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
✅ private-cloud · depot-ubuntu-latest-16 — run #20621 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
✅ oss · depot-ubuntu-latest-arm-16 — run #20621 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
✅ oss · depot-ubuntu-latest-16 — run #20621 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/add-prerequisite #8571 +/- ##
=======================================================
Coverage 98.81% 98.82%
=======================================================
Files 1642 1642
Lines 67497 67690 +193
=======================================================
+ Hits 66700 66893 +193
Misses 797 797 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
600a6cd to
195dffa
Compare
github-actions
Bot
added
feature
Visual Regression19 screenshots compared. See report for details. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Advanced
Run ID: e991a6ab-262a-4e51-b2a7-98bc73197cc7
📒 Files selected for processing (12)
api/environments/urls.pyapi/features/dependencies/exceptions.pyapi/features/dependencies/services.pyapi/features/dependencies/types.pyapi/features/dependencies/views.pyapi/tests/integration/features/conftest.pyapi/tests/integration/features/dependencies/test_dependency_management.pyapi/tests/types.pydocs/docs/deployment-self-hosting/observability/_events-catalogue.mdmcp/src/flagsmith_mcp/openapi.jsonopenapi.yamlsdk/openapi.yaml
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.
github-actions
Bot
added
docs
9d966b6 to
b318ebc
Compare
github-actions
Bot
added
docs
b318ebc to
adc4bfc
Compare
github-actions
Bot
added
docs
This branch was successfully deployed
2 participants
I have added information todocs/if required so people know about the feature.Changes
Closes #8414
Adds two new endpoints:
/api/v1/environments/{key}/features/{feature}/dependencies/will list any prerequisites offeature./api/v1/environments/{key}/features/{feature}/dependents/will list any other features that depend onfeature.Both respond with a list of
DependencyEdgeitems, consistent with the response given when adding a prerequisite (#8413), and in error messages containing a dependency path.As a consequence of a [CodeRabbit] review, the
get_live_or_scheduled_overridesutility recently improved in #8548 receives another upgrade, moving theor_scheduledpiece from the function name to a new kwarg. This adds an extra point of review effort.How did you test this code?
New integration tests.