Skip to content

chore(Segments): Remove unused live-or-scheduled feature version lookup - #8596

Merged
emyller merged 1 commit into
mainfrom
chore/remove-unused-efv-manager-method
Sep 24, 2026
Merged

emyller merged 1 commit into
mainfrom
chore/remove-unused-efv-manager-method

Conversation

@emyller

@emyller emyller commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Contributes to #8587

Segment override lookups no longer rely on the shared "live or scheduled feature versions" lookup, leaving it unused. Removing it keeps new code from reintroducing the query pattern that slowed down the segment list on large installations.

Review effort: 1/5

How did you test this code?

Existing test suite; no behaviour change.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@emyller
emyller requested a review from a team as a code owner September 24, 2026 18:04
@emyller
emyller requested review from matthewelwell and removed request for a team September 24, 2026 18:04
@vercel

vercel Bot commented Sep 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated
docs Ignored Ignored Sep 24, 2026 6:04pm UTC
flagsmith-frontend-preview Ignored Ignored Sep 24, 2026 6:04pm UTC
flagsmith-frontend-staging Ignored Ignored Sep 24, 2026 6:04pm UTC

Request Review

@github-actions github-actions Bot added the chore label Sep 24, 2026
@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: faaaa19c-a5b3-4211-b989-c943cf2fee02

📥 Commits

Reviewing files that changed from the base of the PR and between 0a478c2 and e0eeb24.

📒 Files selected for processing (1)
  • api/features/versioning/managers.py
💤 Files with no reviewable changes (1)
  • api/features/versioning/managers.py

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The EnvironmentFeatureVersionManager no longer defines get_live_or_scheduled. The unused Exists and OuterRef imports have also been removed.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to e0eeb

The removal appears mergeable after normal checks; no affected repository workflow was identified.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the api Issue related to the REST API label Sep 24, 2026
@github-actions

github-actions Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-8596 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-8596 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-8596 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-8596 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-api:pr-8596 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-8596 Finished ✅ Results ✅

@codecov

codecov Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.81%. Comparing base (7619f4c) to head (e0eeb24).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8596   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files        1639     1639           
  Lines       67237    67233    -4     
=======================================
- Hits        66438    66436    -2     
+ Misses        799      797    -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor
✅ private-cloud · depot-ubuntu-latest-16 — run #20811 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  41.9 seconds
commit  e0eeb24
info  🔄 Run: #20811 (attempt 1)

🗂️ Previous results
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #20811 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  35.6 seconds
commit  e0eeb24
info  🔄 Run: #20811 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #20811 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  42.5 seconds
commit  e0eeb24
info  🔄 Run: #20811 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #20811 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  41.8 seconds
commit  e0eeb24
info  🔄 Run: #20811 (attempt 1)

@github-actions

Copy link
Copy Markdown
Contributor

Visual Regression

19 screenshots compared. See report for details.
View full report

@emyller
emyller merged commit ea5ad82 into main Sep 24, 2026
35 checks passed
@emyller
emyller deleted the chore/remove-unused-efv-manager-method branch September 24, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants