Repository navigation
docs(operations): require a landed upstream fix before deleting the forensic volume - #148
Merged
Merged
Conversation
…orensic volume The retention rule released `cotel_cotel-data` when the upstream issue "is resolved". That issue belongs to an unaffiliated reporter who has not answered a maintainer's request for a minimal reproducer, so its likely end state is a close as stale - which satisfies the old wording while the defect is still live and would authorise deleting the only artifact that reproduces it. The rule now asks for a landed fix, and records that the second half (a DuckDB in cotel shown not to hit it) is currently unevaluable rather than satisfied. Also record the mechanism match against `internal/storage/schema.sql`, ban attaching the volume to any public upstream issue (it is production telemetry), and mark the step-2 copy from the 2026-10-04 recovery as deleted on 2026-10-13 so the classification walkthrough matches what `docker volume ls` now shows. Co-Authored-By: Daedalus <daedalus@agents.flopbut.local> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 55 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The retention rule in
docs/operations/duckdb-recovery.mdreleased the forensic volumecotel_cotel-datawhen upstream duckdb#25360 "is resolved". Two problems, both measured today:author_association: NONE) against a ~19 GB database. A maintainer asked that reporter for a minimal reproducer on 2026-10-07 and has had no answer in six days, so the likely end state is a close as stale - which satisfies "is resolved" while the defect is still live, and would authorise deleting the only artifact in existence that reproduces it.duckdb-go/v2 v2.10506.0(DuckDB 1.5.6), the crash was on 1.1.3, and nobody has demonstrated either way.The rule now asks for a landed fix (read the closing commit, not the state) and says the version half is open.
Also in this change:
ALTER TABLEadding a VARCHAR column to a long-lived indexed table plus a large replace transaction, andinternal/storage/schema.sql:53,74addsspans.user_id VARCHARand then indexes that same added column.docker volume lsnow shows (three volumes, not four).Verification
npm run buildindocs/green (VitePress fails the build on broken links).cotel_cotel-dataandcotel-data-backup-20261004returned7eb82bbe…/33e13061…, and the backup was mounted by no container. After the delete the original still returns7eb82bbe…; prodok:true, 74927 spans,restarts=0, snapshot workerok.open, one maintainer comment 2026-10-07, nostate_reason.Docs-only, no behaviour change.
🤖 Generated with Claude Code