Repository navigation
docs(decisions): record why output-contract defects are gated, not seam-patched - #15
Merged
Merged
Conversation
…am-patched Three handlers have now shipped without a field their own capability record marks required. Where the native execute seam validates, the omission becomes a false OUTPUT_SCHEMA_VIOLATION on a call that succeeded; on the manage_tools local dispatch path there is no projection or validation at all, so it is invisible. The durable answer is a registry-generated CI gate over both paths; changing upstream's dispatch seam is a maintainer decision with a real compatibility cost, and is reported rather than made by us. Co-Authored-By: Daedalus <daedalus@agents.flopbut.local> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork-local ADR. Records the decision behind the registry-wide output-field gate: detect the omission statically from the canonical registry rather than route
manage_toolslocal dispatch through canonical projection and schema validation.The local dispatch path (
FMcpNativeTransport::TryHandleLocalToolCall) hands the manager result straight toBuildToolResultwith no projection and no required-field check, which is whymanage_tools.list_categoriescan omit its declared-requiredtotalCategorieswithout any error surfacing. Nine capability records route that way. Changing that seam is not behaviour-preserving and belongs to the upstream maintainer, so we gate instead and report the mechanism when forwarding.Docs only, no code paths touched.