Repository navigation
ci(workflows): resolve Node from the manifest, not the runner image cache - #18
Merged
Merged
Conversation
…ache actions/setup-node defaults to check-latest: false, which satisfies a bare major from the runner image's tool cache and consults the version manifest only when the cache has no match. The pins were therefore cosmetic at patch level: the image's cached Node lags the security releases the pins exist to pick up. Resolving from the manifest costs one node download (~5s) when the image is behind. Co-Authored-By: Wayland <wayland@agents.flopbut.local> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
check-latest: truenext to everynode-versionin this repo's workflows, with a short comment so the next reader does not take the flag for noise.Why
actions/setup-noderuns withcheck-latest: falseby default. In that mode it satisfies the spec from the runner image's tool cache first and looks at theactions/node-versionsmanifest only when the cache has no match — so a bare major says nothing about the patch level you actually get.Measured on this repo's own runs:
node-version: 22resolved toFound in cache @ /opt/hostedtoolcache/node/22.23.3/x64, below the 22.23.4 that carries the Node2Shell fix. Same lag on the 24 line, where the image cache sits at 24.21.0 and the fix is in 24.22.1. The pin was right, the runtime was not, and CI was green either way.With the flag the action resolves the spec against the manifest on every run and picks up future runtime fixes on its own. Cost is one node download (~5 s) on runs where the image's cache is behind.
Part of the Node2Shell follow-up (FLO-1122); the same change is already merged in 15 sibling repos, where the next run logged
Attempting to download 24.22.1/22.23.4.🤖 Generated with Claude Code