Validate multinomial pvals in JAX and PyTorch backends#3220
Merged
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
random.multinomial(..., pvals=...)in the JAX backendpvalsrejection while preserving valid real inputsBug fixed
The NumPy backend already rejects boolean and other non-real multinomial probability vectors, but the JAX and PyTorch backends cast
pvalsdirectly to floating-point tensors/arrays. That silently accepted boolean vectors such as[True, False]as probabilities instead of enforcing the PyRecEst backend contract consistently.Validation
github.com, so I could not clone/install the repository to run fullpytestlocally. The added tests are isolated optional-backend pytest cases and skip cleanly when JAX/PyTorch are unavailable.