Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/pyrecest/_backend/numpy/random.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,21 @@ def randint(low, high=None, size=None, dtype=int):
return _np.random.randint(low, high=high, size=size, dtype=dtype)


def _validate_multinomial_sample_count(n):
if _contains_boolean_value(n):
raise TypeError("n must be a non-negative integer")
try:
n_array = _np.asarray(n)
except (TypeError, ValueError) as exc:
raise TypeError("n must be a non-negative integer") from exc
if n_array.shape != () or n_array.dtype.kind not in "iu":
raise TypeError("n must be a non-negative integer")
count = int(n_array.item())
if count < 0:
raise ValueError("n must be non-negative")
return count


def _validate_multinomial_pvals(pvals):
if _contains_boolean_value(pvals):
raise TypeError("pvals must be real numeric, not boolean")
Expand All @@ -59,5 +74,6 @@ def _validate_multinomial_pvals(pvals):


def multinomial(n, pvals, size=None):
n = _validate_multinomial_sample_count(n)
pvals_array = _validate_multinomial_pvals(pvals)
return _np.random.multinomial(n, pvals_array, size=size)
31 changes: 31 additions & 0 deletions tests/backend/test_numpy_random_backend.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,37 @@ def test_randint_accepts_integer_array_bounds():
assert np.all(samples < high)


@pytest.mark.parametrize(
"n",
[
True,
False,
np.bool_(True),
np.array(True),
np.array([1]),
1.5,
"1",
],
)
def test_multinomial_rejects_non_integer_or_boolean_sample_counts(n):
with pytest.raises(TypeError, match="non-negative integer"):
random.multinomial(n, [1.0])


def test_multinomial_rejects_negative_sample_counts():
with pytest.raises(ValueError, match="non-negative"):
random.multinomial(-1, [1.0])


def test_multinomial_accepts_integer_like_scalar_sample_counts():
random.seed(0)

samples = random.multinomial(np.array(2, dtype=np.int64), [0.25, 0.75], size=3)

assert samples.shape == (3, 2)
assert np.all(samples.sum(axis=1) == 2)


@pytest.mark.parametrize(
("low", "high"),
[
Expand Down
Loading