Skip to content

Accept scalar-array SO3 covariance regularization#3229

Merged
FlorianPfaff merged 2 commits into
mainfrom
fix-so3-covariance-regularization-scalar-arrays
Jun 27, 2026
Merged

Accept scalar-array SO3 covariance regularization#3229
FlorianPfaff merged 2 commits into
mainfrom
fix-so3-covariance-regularization-scalar-arrays

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • allow zero-dimensional NumPy scalar arrays for SO(3) covariance_regularization validation
  • keep booleans, text, non-scalar arrays, negative values, and non-finite values rejected
  • add regression tests for accepted scalar-array values and invalid values

Bug fixed

SO(3) conversion validation treated covariance_regularization as valid only when it was a numbers.Real instance. This incorrectly rejected zero-dimensional NumPy scalar arrays such as np.array(1e-6), even though they represent a valid finite scalar and can naturally arise when regularization is computed with array operations.

Testing

  • python -m py_compile /mnt/data/so3_conversion.py /mnt/data/test_so3_conversion_validation.py

Full repository pytest was not run because this environment could not clone GitHub (Could not resolve host: github.com).

@FlorianPfaff FlorianPfaff enabled auto-merge (squash) June 27, 2026 18:26
@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 70.68s
✅ JSON prettier 7 0 0 0 0.87s
✅ JSON v8r 7 0 0 4.79s
✅ MARKDOWN markdownlint 68 0 0 0 1.5s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.52s
✅ PYTHON black 1048 50 0 0 61.0s
✅ PYTHON isort 1048 71 0 0 4.77s
✅ REPOSITORY checkov yes no no 42.72s
✅ REPOSITORY gitleaks yes no no 11.34s
✅ REPOSITORY git_diff yes no no 0.15s
✅ REPOSITORY secretlint yes no no 31.88s
✅ REPOSITORY syft yes no no 5.03s
✅ REPOSITORY trivy-sbom yes no no 9.77s
✅ REPOSITORY trufflehog yes no no 22.23s
✅ YAML prettier 11 0 0 0 0.62s
✅ YAML v8r 11 0 0 10.18s
✅ YAML yamllint 11 0 0 0.51s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff merged commit 729df7b into main Jun 27, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant