Skip to content

Reject boolean NumPy multinomial sizes#3230

Merged
FlorianPfaff merged 2 commits into
mainfrom
fix-numpy-multinomial-boolean-size
Jun 27, 2026
Merged

Reject boolean NumPy multinomial sizes#3230
FlorianPfaff merged 2 commits into
mainfrom
fix-numpy-multinomial-boolean-size

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • add NumPy-backend validation for random.multinomial(..., size=...) so booleans are not silently treated as sample dimensions
  • add regression coverage for Python, NumPy-scalar, tuple/list, and object-array boolean size inputs
  • keep integer-like scalar size arguments accepted

Bug fixed

np.random.multinomial accepts Python True and False for size, producing (1, k) or (0, k) output shapes. PyRecEst already rejects booleans for sample counts and most random-backend size dimensions; this patch closes the NumPy multinomial gap so boolean size values do not silently change the number of draws.

Validation

  • Inspected the branch diff with GitHub compare: only src/pyrecest/_backend/numpy/random.py and tests/backend/test_numpy_random_backend.py changed.
  • Locally exercised the added size validator against the new boolean cases and an integer-like NumPy scalar size. The execution sandbox cannot resolve github.com, so I could not clone/install the full repository for a complete pytest run.

@FlorianPfaff FlorianPfaff enabled auto-merge (squash) June 27, 2026 18:26
@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 73.54s
✅ JSON prettier 7 0 0 0 1.05s
✅ JSON v8r 7 0 0 5.78s
✅ MARKDOWN markdownlint 68 0 0 0 1.87s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.86s
✅ PYTHON black 1047 49 0 0 68.68s
✅ PYTHON isort 1047 70 0 0 4.86s
✅ REPOSITORY checkov yes no no 48.78s
✅ REPOSITORY gitleaks yes no no 7.59s
✅ REPOSITORY git_diff yes no no 0.17s
✅ REPOSITORY secretlint yes no no 30.86s
✅ REPOSITORY syft yes no no 3.5s
✅ REPOSITORY trivy-sbom yes no no 10.82s
✅ REPOSITORY trufflehog yes no no 22.15s
✅ YAML prettier 11 0 0 0 0.76s
✅ YAML v8r 11 0 0 12.0s
✅ YAML yamllint 11 0 0 0.43s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff merged commit 31f7f24 into main Jun 27, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant