Repository navigation
Pipeline stage added without source hides the pipeline's existing stages #8582
Description
Adding a pipeline stage without source to a pipeline that already has stages doesn't append it. It becomes a second unlinked head, and the pipeline listing then shows only the new stage while the existing ones disappear from it.
Reproduced locally:
before: GET /api/v1/applications/:id/pipelines -> stages: ['GitStage']
POST /api/v1/pipelines/:id/stages {"name":"NoSource","instanceId":"..."} (no source)
after: GET /api/v1/applications/:id/pipelines -> stages: ['NoSource']
GitStage is still there. Fetching it directly at /api/v1/pipelines/:id/stages/VvrL7OLazm returns 200 with its data intact. Both stages have NextStageId: null, so the listing presumably walks from one head and picks the newer one.
The effect is that a single call with a missing source looks like it wiped the pipeline, and the older stages can't be reached through the listing afterwards even though nothing was deleted.
Might be worth either rejecting a source-less stage when the pipeline already has stages, or appending it to the end automatically, or at least having the listing return every stage rather than only the ones reachable from one head.
Metadata
Metadata
Assignees
Type
Projects
- Status
Activity
Mark stage deploys destructive and warn what a missing source does
andypalmi commentedon Sep 22, 2026
Adding a stage without
sourceto a pipeline that already has stages doesn't attach it to the chain. It becomes a second, disconnected stage, and the pipeline listing then shows only that new stage, hiding the existing ones. Nothing is actually deleted, but it looks like the pipeline was wiped.Three ways we could fix this:
sourcewhen the pipeline already has stages. Adding the very first stage still works. Downside: this rejects requests that succeed today.I lean towards option 1, since the point of
sourceis to say where the stage goes, and dropping it should be treated as a mistake rather than silently guessed. Happy to go with 2 if we'd rather be forgiving. Any preference before I pick one up?