homepage: serve / from Nuxt - #5792
Conversation
✅ Deploy Preview for flowforge-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
3912819 to
2ab8cae
Compare
|
Preview affected pages: |
2ab8cae to
dfd3bcb
Compare
dfd3bcb to
cfadd95
Compare
| @@ -0,0 +1,106 @@ | |||
| #!/usr/bin/env python3 | |||
There was a problem hiding this comment.
He dude, if we could do this in node, that would be much better. Now we're not depending on python3 for the website. After this PR, we are?
Would be better to keep it contained.
There was a problem hiding this comment.
Right, and it is node now: scripts/gen-site-art.mjs. Verified it emits a byte-identical nuxt/utils/siteArt.ts apart from its own filename in the generated header. Ported the same way on every branch that carried the script, so nothing here depends on python3.
<HomeHeroSlides> replaces the cross-fading hero background, whose inline script queried the DOM and left two timers running with no teardown; it still honours prefers-reduced-motion by never starting, and clears both on unmount. Three partials become components the page shares with others: testimonials.njk -> <TestimonialCarousel>, social-proof.njk -> <SocialProof>, faq.njk -> <BlogFaq>. cta-get-started.njk was four lines reading a `cta` object the caller set, so it is markup here. explore-more-content.njk was already ported as ThankYouExploreMore for the thank-you pages. The homepage renders the same row, so it is renamed to <ExploreMoreContent> (and ThankYouStoriesBlock to <ExploreMoreStories>). That component linked its webinar without a trailing slash while the site sets trailingSlash: true, so every click took a redirect. Fixed, which also affects the four thank-you pages that render it. site.messaging.heroTagLine and .subtitle are literals here rather than reads through a global. nuxt.config.ts still imports src/_data/site.json for its own config, so nothing is duplicated that teardown will not resolve. Verified against production. The only difference is the webinar button's label case, which comes from the CTA registry and is uppercased by CSS, so it renders the same.
cfadd95 to
89d4a7a
Compare
|
Rebased on One fix from the review pass over the whole migration: the two |
|
Pushed a commit with two fixes:
|
Yndira-E
left a comment
Yndira-E
left a comment
There was a problem hiding this comment.
This is the current state of the homepage bottom section since both blog articles and webinars are now in nuxt
I'm merging now to fix this. If the other reviewers have feedback, that can be address in a follow up pr
|
Following up on the note about other reviewers' feedback going to a later PR. The one thread still open here asked for It is resolved across the board now, not just renamed: So nothing depends on python3 for the website, and there is no generator script left to depend on either. |
This branch was successfully deployed
3 participants
Description
Moves the homepage to Nuxt. The cross-fading hero, the social proof marquee, the testimonial carousel and the FAQ become components.
The hero's second button keeps its white treatment, so it stays legible against the hero image.
Related Issue(s)
Part of #5777
Checklist