Conversation
This was referenced Sep 25, 2026
Contributor
Author
|
FYI: the failing build here isn't caused by this PR. Tracked in https://github.com/FlowFuse/engineering/issues/460. It's resolved now, re-running the checks. |
dimitrieh
force-pushed
the
nuxt/eleventy-teardown
branch
from
September 25, 2026 20:07
6470fc4 to
1621c8d
Compare
The Compress images workflow ignored nuxt/** since images there were meant to be optimised by Nuxt Image at request time. Production builds run build:nuxt:skip-images, which turns Nuxt Image off, so they serve the files as committed, and after the 11ty teardown every tracked image is under nuxt/public/. With the old ignore the workflow still runs on every image PR but compresses nothing, so a new screenshot ships at full size. It now ignores only node_modules/**, the action's own default.
dimitrieh
force-pushed
the
ci/compress-nuxt-images
branch
from
September 25, 2026 20:07
9d2fcf6 to
4fee99c
Compare
Member
|
@dimitrieh While valuable as a change, it slows down the build a lot. I would much rather do this at deploy time through Netlify and make that change next week. We also should review how many |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
Compress imagesworkflow ignoresnuxt/**, meant for images that Nuxt Image optimises at request time. Production runsbuild:nuxt:skip-images, which turns Nuxt Image off, so live pages serve images as committed. After #5795 every tracked image is undernuxt/public/, so the workflow would compress nothing.This narrows the ignore to
node_modules/**, the action's default.Based on 5795 so it cannot merge first: merged earlier, the workflow would recompress the images 5795 moves.
Related Issue(s)
Follow-up to #5777
Checklist