[paodb]

The demo uses VaadinSession, which implements HttpSessionBindingListener. Since Vaadin 25.1 the Servlet API is no longer on the test compile classpath, so the v25 profile now declares jakarta.servlet-api with test scope, as other add-ons do.

Close #25

Summary by CodeRabbit

• Chores
  • Updated the v25 build profile to include the Jakarta Servlet API for test environments.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: cd387e98-a116-425e-bf39-52c5f9a50bce

📥 Commits

Reviewing files that changed from the base of the PR and between b553f7e and 8e0d3a2.

📒 Files selected for processing: 1

• pom.xml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The v25 Maven profile now includes jakarta.servlet-api version 6.1.0 with test scope.

Changes

v25 profile

Layer / File(s)	Summary
Declare the test dependency pom.xml	The v25 profile adds jakarta.servlet-api version 6.1.0 with test scope.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Medium

Suggested reviewers: javier-godoy

Merge Risk: ⚪ Minimal · up to 8e0d3

The v25 test-compilation dependency change is ready to merge.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: adding the test dependency to the Vaadin 25 profile.
Linked Issues check		Issue #25 requires the v25 profile to provide jakarta.servlet-api with test scope for Vaadin 25.1 and later. The reviewed pom.xml declares jakarta.servlet:jakarta.servlet-api version 6.1.0 w…
Out of Scope Changes check		The reviewed change only adds the Servlet API test dependency to the v25 Maven profile. This change directly supports issue #25 and does not introduce unrelated implementation or configuration chang…
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…

Full details: Linked Issues check

Explanation

Issue #25 requires the v25 profile to provide jakarta.servlet-api with test scope for Vaadin 25.1 and later. The reviewed pom.xml declares jakarta.servlet:jakarta.servlet-api version 6.1.0 with <scope>test</scope> inside the v25 profile. This directly supplies the missing test-compile dependency for VaadinSession.

Full details: Out of Scope Changes check

Explanation

The reviewed change only adds the Servlet API test dependency to the v25 Maven profile. This change directly supports issue #25 and does not introduce unrelated implementation or configuration changes.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud