fix(activity-logs): remove errorMessage from updateActivityLogStatus#1576
Merged
fix(activity-logs): remove errorMessage from updateActivityLogStatus#1576
Conversation
…interface
The server Joi validator only accepts { status } in the PATCH body and
rejects any unknown field. errorMessage was added client-side but was
never implemented server-side, causing 400 ValidationFailedError on
every status update call.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Coverage Impact ⬆️ Merging this pull request will increase total coverage on Modified Files with Diff Coverage (2)
🛟 Help
|
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
nbouliol
approved these changes
Apr 30, 2026
forest-bot
added a commit
that referenced
this pull request
Apr 30, 2026
## @forestadmin/forestadmin-client [1.39.5](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/forestadmin-client@1.39.4...@forestadmin/forestadmin-client@1.39.5) (2026-04-30) ### Bug Fixes * **activity-logs:** remove errorMessage from updateActivityLogStatus ([#1576](#1576)) ([19585fc](19585fc))
forest-bot
added a commit
that referenced
this pull request
Apr 30, 2026
## @forestadmin/mcp-server [1.11.7](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/mcp-server@1.11.6...@forestadmin/mcp-server@1.11.7) (2026-04-30) ### Bug Fixes * **activity-logs:** remove errorMessage from updateActivityLogStatus ([#1576](#1576)) ([19585fc](19585fc)) ### Dependencies * **@forestadmin/agent-client:** upgraded to 1.5.6 * **@forestadmin/forestadmin-client:** upgraded to 1.39.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
errorMessagefromUpdateActivityLogStatusParamsinforestadmin-clientmcp-server(source + tests)forestadmin-clientbody construction ({ status }only)Context
The server Joi validator only accepts
{ status }in the PATCH body for activity log status updates.errorMessagewas added to the client interfaces but never implemented server-side, causing400 ValidationFailedError: "errorMessage" is not allowedon every activity log status update call.Test plan
yarn workspace @forestadmin/forestadmin-client test— 283 tests passyarn workspace @forestadmin/mcp-server test— 541 tests pass🤖 Generated with Claude Code
Note
Remove
errorMessagefromupdateActivityLogStatusrequest bodyStrips the
errorMessagefield from activity log status update payloads across theforestadmin-clientandmcp-serverpackages.markActivityLogAsFailednow callsupdateActivityLogStatuswith only{ status: 'failed' }, and theUpdateActivityLogStatusParamsinterface and related types no longer include anerrorMessageproperty.Error.Macroscope summarized a48ca8b.