fix: retrieve WebAuthn credentials inside try/catch OPENAM-26284#587
Open
ForgeRockEmma wants to merge 1 commit intoForgeRock:developfrom
Open
fix: retrieve WebAuthn credentials inside try/catch OPENAM-26284#587ForgeRockEmma wants to merge 1 commit intoForgeRock:developfrom
ForgeRockEmma wants to merge 1 commit intoForgeRock:developfrom
Conversation
🦋 Changeset detectedLatest commit: d14d301 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ForgeRockEmma
force-pushed
the
OPENAM-26284
branch
from
0c98c82 to
48cb4fa
Compare
ForgeRockEmma
force-pushed
the
OPENAM-26284
branch
from
48cb4fa to
d14d301
Compare
cerebrl
approved these changes
May 4, 2026
Contributor
cerebrl
left a comment
cerebrl
left a comment
There was a problem hiding this comment.
This looks good. I'd like @ryanbas21 to take a look as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
OPENAM-26284 This fixes an issue where errors were not being caught and reported to AM
Description
In a previous restructure, getAuthenticationCredential was moved outside of the catch block which populates the HiddenValueCallback. This meant that errors would not be reported to AM.