Conversation
…lues `getStoredAuthUrlValues` can sometimes return null (e.g when the item is not found in storage) and attempting to destructure the return value causes an uncaught runtime error. Changes: - default to empty object with nullish coallescing before destructuring - update `getStoredAuthUrlValues` type definition to reflect actual return type This ensures the proper error handling downstream, where `state` and `verifier` are checked for undefined values, works as intended rather than crashing on destructuring.
chore: update release docs
* feat: add copyright date check & fix automation * feat: validate space around dates; update tests; * fix: update test input dates * fix: add exclude paths to pre-commit date update; update test input dates; * feat: enforce copyright headers via eslint-plugin-header
fix: retrieve WebAuthn credentials inside try/catch OPENAM-26284
|
View your CI Pipeline Execution ↗ for commit aa922bf
☁️ Nx Cloud last updated this comment at |
commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #588 +/- ##
==========================================
- Coverage 58.53% 56.72% -1.81%
==========================================
Files 105 105
Lines 28448 28456 +8
Branches 1802 1644 -158
==========================================
- Hits 16652 16142 -510
- Misses 11796 12314 +518 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fix: prevent destructuring error when reading from stored values
github-actions
Bot
force-pushed
the
changeset-release/master
branch
from
aa922bf to
293f273
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.
Releases
@forgerock/javascript-sdk@4.9.1
Patch Changes
d14d301Thanks @ForgeRockEmma! - fix: move getAuthenticationCredential back inside try/catch so that WebAuthn cancellation errors (e.g. NotAllowedError) are written to the HiddenValueCallback before re-throwing@forgerock/ping-protect@4.7.1
Patch Changes
d14d301]:@forgerock/token-vault@4.2.2
Patch Changes
d14d301]: