Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughRemoved several changeset files and bumped many package versions from 2.0.0 → 2.1.0 with corresponding 2.1.0 changelog entries (noting dependency bumps and sdk-effects distribution fixes). Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 3ea55ca
☁️ Nx Cloud last updated this comment at |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/sdk-utilities/CHANGELOG.md`:
- Line 7: Replace the malformed changelog entry string "Updated dependencies
[]:" with a proper heading such as "Updated dependencies:" or, if there are
specific packages, replace the empty brackets with a comma-separated list of the
updated packages; locate the exact token "Updated dependencies []:" in
CHANGELOG.md and remove the empty square brackets or populate them with the
dependency names so the line reads correctly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 80c258cc-8a08-4435-80ff-d329f5cf4beb
📒 Files selected for processing (25)
.changeset/odd-parents-joke.mdpackages/davinci-client/CHANGELOG.mdpackages/davinci-client/package.jsonpackages/device-client/CHANGELOG.mdpackages/device-client/package.jsonpackages/journey-client/CHANGELOG.mdpackages/journey-client/package.jsonpackages/oidc-client/CHANGELOG.mdpackages/oidc-client/package.jsonpackages/protect/CHANGELOG.mdpackages/protect/package.jsonpackages/sdk-effects/iframe-manager/CHANGELOG.mdpackages/sdk-effects/iframe-manager/package.jsonpackages/sdk-effects/logger/CHANGELOG.mdpackages/sdk-effects/logger/package.jsonpackages/sdk-effects/oidc/CHANGELOG.mdpackages/sdk-effects/oidc/package.jsonpackages/sdk-effects/sdk-request-middleware/CHANGELOG.mdpackages/sdk-effects/sdk-request-middleware/package.jsonpackages/sdk-effects/storage/CHANGELOG.mdpackages/sdk-effects/storage/package.jsonpackages/sdk-types/CHANGELOG.mdpackages/sdk-types/package.jsonpackages/sdk-utilities/CHANGELOG.mdpackages/sdk-utilities/package.json
💤 Files with no reviewable changes (1)
- .changeset/odd-parents-joke.md
|
|
||
| ### Patch Changes | ||
|
|
||
| - Updated dependencies []: |
There was a problem hiding this comment.
Fix malformed dependency note formatting.
Line 7 includes empty brackets (Updated dependencies []:), which reads like a broken reference token in the published changelog.
Suggested fix
-- Updated dependencies []:
+- Updated dependencies:📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - Updated dependencies []: | |
| - Updated dependencies: |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/sdk-utilities/CHANGELOG.md` at line 7, Replace the malformed
changelog entry string "Updated dependencies []:" with a proper heading such as
"Updated dependencies:" or, if there are specific packages, replace the empty
brackets with a comma-separated list of the updated packages; locate the exact
token "Updated dependencies []:" in CHANGELOG.md and remove the empty square
brackets or populate them with the dependency names so the line reads correctly.
@forgerock/davinci-client
@forgerock/device-client
@forgerock/journey-client
@forgerock/oidc-client
@forgerock/protect
@forgerock/sdk-types
@forgerock/sdk-utilities
@forgerock/iframe-manager
@forgerock/sdk-logger
@forgerock/sdk-oidc
@forgerock/sdk-request-middleware
@forgerock/storage
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (17.51%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #561 +/- ##
===========================================
- Coverage 70.90% 17.51% -53.40%
===========================================
Files 53 154 +101
Lines 2021 24151 +22130
Branches 377 1145 +768
===========================================
+ Hits 1433 4229 +2796
- Misses 588 19922 +19334 🚀 New features to boost your workflow:
|
|
Deployed b43028e to https://ForgeRock.github.io/ping-javascript-sdk/pr-561/b43028e6d2bd8034034687fbd5cc37512239745f branch gh-pages in ForgeRock/ping-javascript-sdk |
📦 Bundle Size Analysis📦 Bundle Size Analysis🚨 Significant Changes🔻 @forgerock/device-client - 0.0 KB (-10.0 KB, -100.0%) ➖ No Changes➖ @forgerock/device-client - 10.0 KB 14 packages analyzed • Baseline from latest Legend🆕 New package ℹ️ How bundle sizes are calculated
🔄 Updated automatically on each push to this PR |
ryanbas21
force-pushed
the
changeset-release/main
branch
5 times, most recently
from
12796e0 to
cd3b148
Compare
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ryanbas21
force-pushed
the
changeset-release/main
branch
3 times, most recently
from
e3fc7d7 to
74ba085
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ryanbas21
force-pushed
the
changeset-release/main
branch
4 times, most recently
from
1eb6e76 to
f8940b8
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ryanbas21
force-pushed
the
changeset-release/main
branch
from
f8940b8 to
4de5a4e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ryanbas21
force-pushed
the
changeset-release/main
branch
5 times, most recently
from
4ad345e to
4ba1c7d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ryanbas21
force-pushed
the
changeset-release/main
branch
from
4f4e766 to
56dfa21
Compare
ryanbas21
force-pushed
the
changeset-release/main
branch
from
56dfa21 to
3ea55ca
Compare
2 participants
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@forgerock/davinci-client@2.1.0
Minor Changes
#562
63e94aaThanks @ryanbas21! - Add QR code collector support to davinci-client#563
ec39137Thanks @ancheetah! - AddspollStatus()method andPollingCollectorto@forgerock/davinci-clientfor polling support in DaVinci flows.Pass a
PollingCollectortodavinciClient.pollStatus(collector)to get a poller function. The polling mode is detected automatically from the collector:/statusendpoint until the challenge is resolved.Adds ability to intercept the polling request with middleware.
#579
6c13d93Thanks @ancheetah! - Support form agreements with AgreementCollectorPatch Changes
#564
15d5af3Thanks @ryanbas21! - Update interfaces and types that are missing from exportsUpdated dependencies [
ec39137,d849256]:@forgerock/journey-client@2.1.0
Minor Changes
07015a2Thanks @vatsalparikh! - Add WebAuthn conditional mediation (passkey autofill) support.WebAuthn.authenticate(step, signal?)derives mediation from WebAuthn metadata (meta.mediation).meta.mediationis'conditional', anAbortSignalis used (caller-provided if present, otherwise created by the SDK).authenticate()throwsNotSupportedError(and the existing error handling sets the hidden outcome tounsupported).WebAuthn.isConditionalMediationSupported()helper, docs, and unit tests.Patch Changes
#564
15d5af3Thanks @ryanbas21! - Update interfaces and types that are missing from exports#583
b081582Thanks @vatsalparikh! - Restore legacy resume() redirect query-param handling.resume() now parses and forwards additional URL params (error, errorCode, errorMessage, nonce, RelayState, scope, suspendedId) and uses authIndexValue as a fallback journey value.
#557
5fe2f41Thanks @ryanbas21! - ExtendJourneyClientConfigfromAsyncLegacyConfigOptionsso the same config object can be shared across journey-client, davinci-client, and oidc-clientclientId,scope,redirectUri, and other inherited properties are now accepted but ignored — a warning is logged when they are providedserverConfig.wellknownremains required#578
096733dThanks @SteinGabriel! - SupportsignalsInitializationOptionspass-through config from AM inPingOneProtectInitializeCallback.getConfig()detectssignalsInitializationOptionsin the callback output; if it is a valid plain object, returns it directly asSignalsInitializationOptionsProtectConfigconstruction when the property is absent or invalid (null, string, array)protect()now acceptsProtectConfig | SignalsInitializationOptionsso the pass-through config flows in without type assertionsUpdated dependencies [
ec39137,d849256]:@forgerock/sdk-request-middleware@2.1.0
Minor Changes
#563
ec39137Thanks @ancheetah! - AddspollStatus()method andPollingCollectorto@forgerock/davinci-clientfor polling support in DaVinci flows.Pass a
PollingCollectortodavinciClient.pollStatus(collector)to get a poller function. The polling mode is detected automatically from the collector:/statusendpoint until the challenge is resolved.Adds ability to intercept the polling request with middleware.
Patch Changes
d849256Thanks @ancheetah! - Fixes files distributed in sdk-effects packages. Excludes files not in/distfolder.@forgerock/device-client@2.1.0
Patch Changes
15d5af3Thanks @ryanbas21! - Update interfaces and types that are missing from exports@forgerock/oidc-client@2.1.0
Patch Changes
#564
15d5af3Thanks @ryanbas21! - Update interfaces and types that are missing from exportsUpdated dependencies [
ec39137,d849256]:@forgerock/protect@2.1.0
Patch Changes
096733dThanks @SteinGabriel! - SupportsignalsInitializationOptionspass-through config from AM inPingOneProtectInitializeCallback.getConfig()detectssignalsInitializationOptionsin the callback output; if it is a valid plain object, returns it directly asSignalsInitializationOptionsProtectConfigconstruction when the property is absent or invalid (null, string, array)protect()now acceptsProtectConfig | SignalsInitializationOptionsso the pass-through config flows in without type assertions@forgerock/iframe-manager@2.1.0
Patch Changes
d849256Thanks @ancheetah! - Fixes files distributed in sdk-effects packages. Excludes files not in/distfolder.@forgerock/sdk-logger@2.1.0
Patch Changes
d849256Thanks @ancheetah! - Fixes files distributed in sdk-effects packages. Excludes files not in/distfolder.@forgerock/sdk-oidc@2.1.0
Patch Changes
#555
d849256Thanks @ancheetah! - Fixes files distributed in sdk-effects packages. Excludes files not in/distfolder.Updated dependencies []:
@forgerock/storage@2.1.0
Patch Changes
#555
d849256Thanks @ancheetah! - Fixes files distributed in sdk-effects packages. Excludes files not in/distfolder.Updated dependencies []:
@forgerock/sdk-utilities@2.1.0
Patch Changes
@forgerock/sdk-types@2.1.0