Repository navigation
fix(core): stop scoring generic XML feed media types - #85
Merged
Merged
Conversation
A feed served as application/xml or text/xml now passes feed-entry-identity-and-canonical-integrity instead of returning warn. Every feed reader parses a generic XML type, no source names a consumer that treats it worse, and application/rss+xml was never registered with IANA. The type is still recorded under details.warnings; a non-XML type such as text/html still fails. Also redefine the changeset bump rule in AGENTS.md: major means the output contract changes, minor means it grows, and patch means a verdict is corrected to match its dossier with id, tier, grade, weight and schema unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
machine-discovery/feed-entry-identity-and-canonical-integrityno longer returnswarnfor a feed served asapplication/xmlortext/xml. The warn cost half of a grade-B scored audit (0.3 weight) with no consumer source behind it.application/rss+xmlwas never registered with IANA, so the old message ("the registered rss media type") was false. Only Atom'sapplication/atom+xmlis registered (RFC 4287).details.warnings, so the result schema is unchanged. A non-XML type such astext/htmlstill fails.AGENTS.md(symlinked asCLAUDE.md): the changeset bump rule now follows the output contract instead of "any verdict moved":Found on https://dwithease.com, which serves
/rss.xmlasapplication/xml.Changeset
@forkpoint/agent-lighthouse-core: patch, under the new rule.Test plan
pnpm build && AL_SKIP_NETWORK=1 pnpm test && pnpm typecheck && pnpm lint && pnpm check:dossiers && pnpm check:requires && pnpm check:audit-maptext/xmlandapplication/xml(pass, type noted) andtext/html(fail)