Repository navigation
Conversation
Nested Review, Comment, Answer and Question dates record when someone else wrote, not when the page changed. Reading them as page signals reported product pages that publish no page date as divergent instead of unverifiable. Count lastmods within one hour as one build stamp. A generator that writes the clock per URL spreads one run over seconds, and exact string matching missed it.
k2kirov
force-pushed
the
fix/lastmod-verifiability-page-signals
branch
from
October 6, 2026 09:17
8b0eef5 to
8b2e2c3
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two false readings in
machine-discovery/sitemap-lastmod-verifiability, found on a large retail site.1. Review dates counted as page dates. The audit read
dateModified/datePublishedfrom every JSON-LD node, nested ones included. the site product pages publish no page date but nest customer reviews ("review":[{"@type":"Review","datePublished":...}]). Five pages were reported 26–55 days "divergent" from review dates. The audit now reads top-level nodes,@graphmembers and what they nest, minus nestedReview,Comment,AnswerandQuestion. A top-levelReviewkeeps its dates.2. Build stamps written seconds apart were missed. The modal test compared lastmod strings exactly. the site stamped 2451 product URLs between 09:57:16 and 09:57:33 on one day; exact matching saw 2451 distinct dates. The audit now counts the largest group of sampled values inside a one-hour window. The 90% share and 3-day recency rules are unchanged.
Also corrects a code comment that said the modal test counts only compared URLs; it counts the whole sample, as the dossier specifies.
Verification
AL_SKIP_NETWORK=1), typecheck, lint, check:dossiers, check:requires, check:audit-map, format:check all pass.fail(0 corroborated, 5 divergent, 1 unverifiable) ->warn(6 unverifiable, "add dateModified"). The build stamp does not fire there: the run is 4 days old, past the 3-day recency rule.Dossier: two implementation deviations added. Patch changeset.
Independent of #88.