fix: correct disposal ordering to prevent ObjectDisposedException during shutdown#89
Merged
Conversation
…ing shutdown Call SignalDispose() before disposing resources to cancel background tasks before the CancellationTokenSource is disposed. Move base.Dispose() to the end to ensure the CTS stays alive while resources are being cleaned up. Fixes same class of bug as FoundatioFx/Foundatio.Redis#165.
Collapse separate IsDisposed check + SignalDispose() call into single atomic operation that eliminates the TOCTOU gap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This prevents a potential ObjectDisposedException if the CancellationTokenSource is disposed while background tasks are still checking the token -- the same class of bug fixed in FoundatioFx/Foundatio.Redis#165.
Related
Test plan