fix(python): quote fql anchor values - #253
Open
kkkhs wants to merge 7 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
RonsenbergVI
self-requested a review
September 5, 2026 15:56
RonsenbergVI
previously approved these changes
Sep 5, 2026
RonsenbergVI
left a comment
RonsenbergVI
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Thanks for the contribution!
…values # Conflicts: # sdk/python/src/fraise_sdk/query.py
RonsenbergVI
self-requested a review
September 14, 2026 07:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Type of change
Description of the changes
Quote Python SDK topic/entity clause values as FQL values, and quote recall terms that contain syntax-significant characters.
Motivation for the changes
This keeps model- or user-supplied anchors and recall terms from being parsed as FQL structure or rejected by the parser. Closes #234.
Breaking change?
If yes, fill this in
What breaks:
Before → after:
Migration:
How it was tested
uvx --from uv==0.11.0 uv run --package fraise-sdk --all-extras pytest sdk/python/src/tests/query_test.py -m 'not integration'make test-py UV_CMD='uvx --from uv==0.11.0 uv'git diff --checkuvx --from ruff==0.16.0 ruff check --config=pyproject.toml sdk/python/src/fraise_sdk/query.py sdk/python/src/tests/query_test.py sdk/python/src/tests/client_test.pyuvx --from ruff==0.16.0 ruff format --check --config=pyproject.toml sdk/python/src/fraise_sdk/query.py sdk/python/src/tests/query_test.py sdk/python/src/tests/client_test.pymake test-integration-py UV_CMD='uvx --from uv==0.11.0 uv'(local environment has nodockerbinary).make lint-py UV_CMD='uvx --from uv==0.11.0 uv'(local Git is 2.20.1 and pre-commit callsgit ls-files --deduplicate).Checklist
Notes for reviewers