gl: add profile-neutral GLSL dispatch and core test support by tritao · Pull Request #65 · FreeCAD/coin

tritao · 2026-08-18T18:39:50Z

Summary

Make Coin's GLSL implementation independent of compatibility-profile entry points and establish reusable core-profile GL test support.

Add profile-neutral GLSL dispatch with core entry points and ARB fallbacks.
Query extensions safely when compatibility-only extension-string access is unavailable.
Migrate shader objects, programs, parameters, and stage nodes to the neutral dispatch layer.
Add GLSLRuntimeTest coverage for shader compilation, linking, uniforms, and execution in a core-profile context.
Add shared hidden-GLFW context and framebuffer support under testsuite/support/ for generic GL tests.
Expose the small generic GL dispatch surface needed by the shared test support.

This layer does not own EGL display/context lifecycle or caller-state restoration; that remains in PR #12. Shader diagnostic/source-attribution behavior is intentionally left to PR #22.

This PR replaces #14, which GitHub recorded as merged while the active renderer stack was being repaired. The implementation remains on the existing stack/profile-neutral-shaders branch so later layers retain their original ancestry.

Stack

Layer 3/18, based on PR #12. PR #22 is the next layer.

Lgt2x · 2026-08-19T08:52:28Z


 option(COIN_BUILD_SHARED_LIBS "Build shared library when ON (default), static when OFF." ON)
 option(COIN_BUILD_TESTS "Build unit tests when ON (default), skips them when OFF." ON)
+option(COIN_FETCH_TEST_DEPENDENCIES


I prefer respecting the FreeCAD policy of not pulling dependencies using the build system but requiring them externally using find_package. This adds "superbuild" complexity that is not actually necessary

Agreed. FetchContent is removed. Coin uses , with dependencies provisioned externally through native package managers.

Lgt2x · 2026-08-19T08:54:21Z

+#define COIN_GLUE_GLSLP_H
+
+/**************************************************************************\
+ * Copyright (c) Kongsberg Oil & Gas Technologies AS


may not be a question for you but do we need to keep the Kongsberg copyright for new files?

Lgt2x · 2026-08-19T08:57:07Z

what is 'p' supposed to mean in the filename?

It means private I think, it's a previously existing Coin convention.

Lgt2x · 2026-08-19T08:59:13Z

+cc_glglue_glGetUniformLocation(const cc_glglue * glue, GLuint program,
+                               const char * name)
+{
+  if (glue->glGetUniformLocation) return glue->glGetUniformLocation(program, name);
+  if (glue->glGetUniformLocationARB) {
+    return glue->glGetUniformLocationARB((COIN_GLhandle) program,
+                                         (const COIN_GLchar *) name);
+  }
+  return -1;
+}


move impl to glslp.cpp? this file is already long enough

Lgt2x · 2026-08-19T09:00:14Z

 }


+/* Standard-facing shader wrappers.  Keeping the fallback here means shader


standard-facing?

Lgt2x · 2026-08-19T09:17:13Z

+		${PROJECT_SOURCE_DIR}/src
+		${PROJECT_SOURCE_DIR}/include
+		${PROJECT_BINARY_DIR}/include


I would be surprised that these directories are not included when you link the test executable target with Coin

Lgt2x · 2026-08-19T09:18:17Z

+	target_include_directories(GLSLRuntimeTest PRIVATE
+		${PROJECT_SOURCE_DIR}/src
+		${PROJECT_SOURCE_DIR}/include
+		${PROJECT_BINARY_DIR}/include
+		${COIN_TARGET_INCLUDE_DIRECTORIES})


redundant with public includes from CoinGLTestSupport, this should not be necessary

Lgt2x · 2026-08-19T09:20:24Z

+int skip(const char * reason)
+{
+  std::cout << "SKIP: " << reason << std::endl;
+  return 77;
+}
+
+bool check(bool condition, const char * message)
+{
+  if (!condition) std::cerr << "FAIL: " << message << std::endl;
+  return condition;
+}


at this point, we can think about a small header for test utilities defining classic CHECK, SKIP macros

Lgt2x · 2026-08-19T09:21:12Z

+  std::vector<uint8_t> readPixels() const;
+
+private:
+  const cc_glglue * glue_;


is suffixing with a _ common in this code base? I don't see the point

Lgt2x · 2026-08-19T09:21:42Z

+  int width() const { return width_; }
+  int height() const { return height_; }
+
+  std::vector<uint8_t> readPixels() const;


doc at least the pixel order format

tritao · 2026-08-19T12:14:18Z

Thanks for the review. I rewrote the PR around the feedback:

Moved GLSL dispatch into its own private implementation.
Added explicit core/ARB availability checking.
Simplified the shared GLFW test support and CMake linkage.
Removed FetchContent in favor of external, native dependency provisioning.

tritao changed the title ~~stack/profile neutral shaders~~ gl: add profile-neutral GLSL dispatch and core test support Aug 18, 2026

tritao force-pushed the stack/profile-neutral-shaders branch from ca87a6a to a6f4a6d Compare August 18, 2026 19:51

tritao mentioned this pull request Aug 18, 2026

shaders: improve GLSL diagnostics and source attribution #22

Open

tritao force-pushed the stack/profile-neutral-shaders branch 2 times, most recently from 59b3a2c to e5bdbba Compare August 19, 2026 01:16

tritao force-pushed the stack/profile-neutral-shaders branch 2 times, most recently from acffc99 to b57eac0 Compare August 19, 2026 02:14

Lgt2x reviewed Aug 19, 2026

View reviewed changes

tritao force-pushed the stack/profile-neutral-shaders branch from b57eac0 to 564a6c8 Compare August 19, 2026 10:22

tritao force-pushed the stack/profile-neutral-shaders branch from 3a1313c to 02d5615 Compare August 19, 2026 10:28

tritao mentioned this pull request Aug 19, 2026

build: establish profile-aware OpenGL headers #11

Open

tritao force-pushed the stack/profile-neutral-shaders branch 2 times, most recently from e92e352 to 3ddbee8 Compare August 19, 2026 12:08

tritao force-pushed the stack/profile-neutral-shaders branch 4 times, most recently from 2cefee8 to 61a4642 Compare August 19, 2026 13:16

tritao added 3 commits August 19, 2026 14:54

gl: add profile-neutral GLSL dispatch

19d829c

glue: query extensions safely in core contexts

cc5a859

shaders: migrate GLSL to profile-neutral dispatch

a763152

tritao added 3 commits August 19, 2026 14:54

build: separate private access from Coin producer role

1a6f82c

tests: validate GLSL with shared GLFW support

b593de1

ci: provision GLFW test dependencies natively

a3891c3

tritao force-pushed the stack/profile-neutral-shaders branch from 61a4642 to a3891c3 Compare August 19, 2026 13:56

Navigation Menu

Uh oh!

gl: add profile-neutral GLSL dispatch and core test support - #65

gl: add profile-neutral GLSL dispatch and core test support#65
tritao wants to merge 6 commits into
stack/egl-offscreenfrom
stack/profile-neutral-shaders

tritao commented Aug 18, 2026 •

edited

Loading

Uh oh!

Lgt2x Aug 19, 2026

Uh oh!

tritao Aug 19, 2026

Uh oh!

Lgt2x Aug 19, 2026

Uh oh!

Lgt2x Aug 19, 2026

Uh oh!

tritao Aug 19, 2026

Uh oh!

Lgt2x Aug 19, 2026

Uh oh!

Lgt2x Aug 19, 2026

Uh oh!

Lgt2x Aug 19, 2026

Uh oh!

Lgt2x Aug 19, 2026

Uh oh!

Lgt2x Aug 19, 2026

Uh oh!

Lgt2x Aug 19, 2026

Uh oh!

Lgt2x Aug 19, 2026

Uh oh!

tritao commented Aug 19, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		}


		/* Standard-facing shader wrappers. Keeping the fallback here means shader

Uh oh!

Conversation

tritao commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Stack

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tritao commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tritao commented Aug 18, 2026 •

edited

Loading

tritao commented Aug 19, 2026 •

edited

Loading