You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(auth): enforce payment permission eligibility in pre-verified order status completion #1207
In PATCH /api/orders/:id/status, completing an unpaid order requires the approver to possess both orders.status.update and payments.take.
In PR #1197, asynchronous pre-verification only checked orders.status.update. When multiple managers share a PIN (or in fallback scanning), pre-verification can stop at a manager lacking payments.take. The subsequent transaction revalidation then rejects the approver with 403 Invalid manager PIN, skipping any subsequent managers with matching PINs who hold the required permission.
Expected Behavior
Pre-verification candidate filtering must enforce the exact same eligibility rules as transaction revalidation (including payments.take when completing unpaid orders).
Maintain manager selection binding when explicit approver ID is provided.
changed the title [-]fix(auth): enforce payment permission eligibility in pre-verified order status completion (#1197)[/-][+]fix(auth): enforce payment permission eligibility in pre-verified order status completion[/+]on Oct 18, 2026
Activity
[-]fix(auth): enforce payment permission eligibility in pre-verified order status completion (#1197)[/-][+]fix(auth): enforce payment permission eligibility in pre-verified order status completion[/+]fix(main): restore payment replay idempotency and revalidate discount…
fix(main): enforce payment permission eligibility in pre-verified ord…
khaira777 commentedon Oct 20, 2026
Verified and delivered on
mainvia PR #1214.