Skip to content

fix(auth): enforce payment permission eligibility in pre-verified order status completion #1207

Closed

Description

@khaira777

Description

In PATCH /api/orders/:id/status, completing an unpaid order requires the approver to possess both orders.status.update and payments.take.
In PR #1197, asynchronous pre-verification only checked orders.status.update. When multiple managers share a PIN (or in fallback scanning), pre-verification can stop at a manager lacking payments.take. The subsequent transaction revalidation then rejects the approver with 403 Invalid manager PIN, skipping any subsequent managers with matching PINs who hold the required permission.

Expected Behavior

  • Pre-verification candidate filtering must enforce the exact same eligibility rules as transaction revalidation (including payments.take when completing unpaid orders).
  • Maintain manager selection binding when explicit approver ID is provided.

Activity

  1. changed the title [-]fix(auth): enforce payment permission eligibility in pre-verified order status completion (#1197)[/-] [+]fix(auth): enforce payment permission eligibility in pre-verified order status completion[/+] on Oct 18, 2026
  2. khaira777 commented on Oct 20, 2026

    @khaira777
    ContributorAuthor

    Verified and delivered on main via PR #1214.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions