Add workflows to optimize PNG & SVG files - #9719
Open
PikachuEXE wants to merge 10 commits into
Open
PikachuEXE wants to merge 10 commits into
PikachuEXE wants to merge 10 commits into
Conversation
FreeTubeBot
enabled auto-merge (squash)
August 31, 2026 02:03
github-actions
Bot
added
the
PR: waiting for review
PikachuEXE
marked this pull request as draft
August 31, 2026 02:12
auto-merge was automatically disabled
August 31, 2026 02:12
Pull request was converted to draft
github-actions
Bot
removed
the
PR: waiting for review
Member
Author
|
File diff one failed due unable to fetch branch from |
efb4f5ff-1298-471a-8973-3d47447115dc
requested changes
Sep 3, 2026
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
Member
There was a problem hiding this comment.
Failed to see that this PR was opened
PikachuEXE
force-pushed
the
dev/image-optimize-pr
branch
from
September 9, 2026 23:25
1c12f90 to
c54c15e
Compare
Member
Author
|
Workflow updated with new action which generates part of PR body with file diff But probably will wait for #9766 to be merged |
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
Member
There was a problem hiding this comment.
I was looking at https://github.com/FreeTubeApp/FreeTube/blob/development/.github/workflows/conflicts.yml#L13-L15 and we probably also want to add concurrency too in the rare case that 2pr's are merged that contain images so it wont create 2 separate pr's
In our case it will look like
concurrency:
group: compress-images-${{ github.ref }}
cancel-in-progress: true
Member
|
Also add workflow to ignore list https://github.com/FreeTubeApp/FreeTube/blob/development/.github/workflows/build.yml#L9-L22 |
* development: (30 commits) Add handling for `/show/` urls (FreeTubeApp#9788) Translated using Weblate (Portuguese (Brazil)) Feature/drag drop improve (FreeTubeApp#9591) cleanup leftover from workflow removal (FreeTubeApp#9792) Translated using Weblate (Icelandic) Translated using Weblate (Azerbaijani) Bump vue-router from 5.3.0 to 5.3.1 (FreeTubeApp#9779) Bump marked from 18.0.11 to 18.0.12 (FreeTubeApp#9780) Bump electron-builder from 26.15.7 to 26.16.1 (FreeTubeApp#9781) Bump dompurify from 3.4.14 to 3.4.15 (FreeTubeApp#9784) Bump the webpack group across 1 directory with 2 updates (FreeTubeApp#9778) Translated using Weblate (French) Bump the eslint group with 4 updates (FreeTubeApp#9775) Bump pnpm/action-setup from 6.0.10 to 6.1.0 (FreeTubeApp#9776) Translated using Weblate (Japanese) Translated using Weblate (Turkish) Translated using Weblate (Slovak) Translated using Weblate (Czech) Translated using Weblate (German) Hoist some v-ifs and use v-else and v-else-if (FreeTubeApp#9768) ...
Member
Author
|
Changes made |
PikachuEXE
marked this pull request as ready for review
September 14, 2026 05:42
FreeTubeBot
enabled auto-merge (squash)
September 14, 2026 05:42
github-actions
Bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Sep 14, 2026
Shadorc
reviewed
Sep 14, 2026
Member
|
@PikachuEXE you might want to update pr body |
Shadorc
approved these changes
Sep 14, 2026
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
Existing image compression workflow seems broken and thus removed in #9686
Description
Workflows for compressing images like what's done in #9685
One for image compression and PR opening (PR body about file diff generation done inside)
Screenshots
Testing
I run new workflow manually which opened PikachuEXE#99 (file details should be default close but I forgot to commit that change before running)
See workflow runs in
Desktop
Additional context
Some previous discussion in PikachuEXE#87
Using https://github.com/PikachuEXE/FreeTube/tree/dev/image-optimize to test workflow runs (files there slightly different from PR