Feat: Add a reload button to the player video info bar so you can recover after the player crashes

[mousetail]

Pull Request Type

• Bugfix
• Feature Implementation
• Documentation
• Other

Related issue

Closes #1005

Description

Currently, sometimes the player gets stuck (session timeout, crash, IP ban, etc.) Right now, the only way to recover from this is to go to your history page, find the video again, then load it. It's not a lot of effort but a bit annoying, especially when the video never actually played so it doesn't show in your history and you need to scroll through the channel page again.

This adds a button next to the share and format options to reload the player.

Screenshots

Testing

This is fairly easy to test. Just open a video, and click the new button and see the page reloads.

Desktop

• **OS: ** Linux
• OS Version: 7.0.10-1 MANJARO
• FreeTube version: Development

Additional context

I discussed some thing about this in chat

[radmorecameron]

Haven't tested yet, my initial thought is this seems like a good compromise for the hacky "reload" being removed.

Without having tested this, I feel like our debounce function should probably be used for onManualReloadReloadRequested?

FreeTube/src/renderer/helpers/utils.js

Line 1074 in f7acbc7

export function debounce(func, wait) {

[caetano-dev]

Haven't tested yet, my initial thought is this seems like a good compromise for the hacky "reload" being removed.

Without having tested this, I feel like our debounce function should probably be used for onManualReloadReloadRequested?

FreeTube/src/renderer/helpers/utils.js

Line 1074 in f7acbc7

export function debounce(func, wait) {

Maybe the throttle function would be better, because it executes immediately. debounce has to wait after it is called.

[Shadorc]

Now that manually reloading the player is a valid feature, #9552 (comment) should probably be reconsidered?
@efb4f5ff-1298-471a-8973-3d47447115dc
On second thought, it does not seem useful if it is manually triggered

[absidue]

Refresh page would probably be a more appropriate name as it refreshed everything except the playlist and comments.

[mousetail]

I changed it to Reload Page

[Shadorc]

I get this

[mousetail]

I get this

Fixed

After:

[ArthurKun21]

Couldn't the "Reload" button be actually the same color as refresh in the subscriptions page?

[efb4f5ff-1298-471a-8973-3d47447115dc]

Couldn't the "Reload" button be actually the same color as refresh in the subscriptions page?

I dont think thats a good idea because that will make users associate it with a certain behavior even though the underlying functionality is totally different.

Also that would break the color scheme that is being used by the buttons beside it

[ArthurKun21]

it is just that, the placement was last place I would think of for reload.

Was originally gonna propose to add it on the top like similar to the browsers

But might seem like a bit of more work, so I just proposed to change the color which is less work to make it more noticeable

[mousetail]

Was originally gonna propose to add it on the top like similar to the browsers

But might seem like a bit of more work, so I just proposed to change the color which is less work to make it more noticeable

This was discussed in the Matrix, but it doesn't fit that well because reload does something very different for different pages or is not relevant at all for most of them. The UX would be weird and in addition it needs a communication channel between the top bar and the page which breaks the seperation