Skip to content

Feat: Improve messaging when all channel videos are filtered out - #9791

Open
Shadorc wants to merge 2 commits into
FreeTubeApp:developmentfrom
Shadorc:feat/filetered-videos
Open

Shadorc wants to merge 2 commits into
FreeTubeApp:developmentfrom
Shadorc:feat/filetered-videos

Conversation

@Shadorc

@Shadorc Shadorc commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

closes #9678

Description

Add a specific message when a channel contains videos but they were all filtered. This can happen if videos are for members only.
I have removed This channel does not currently have any videos key because it can't be displayed. Videos tab is not displayed if there are no videos, see https://github.com/FreeTubeApp/FreeTube/blob/development/src/renderer/views/Channel/Channel.vue#L792

Screenshots

image

Testing

  1. Go to https://www.youtube.com/channel/UC2EiGVmCeD79l_vZ204DUSw/videos
  2. Check that the message is "This channel has videos but none could be displayed, try fetching more"
  3. Click on Fetch more results
  4. See more content being loaded

Desktop

  • OS: Bazzite
  • OS Version:
  • FreeTube version: v0.25.3-beta

@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) September 13, 2026 12:01
@github-actions github-actions Bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 13, 2026
@efb4f5ff-1298-471a-8973-3d47447115dc

efb4f5ff-1298-471a-8973-3d47447115dc commented Sep 13, 2026

Copy link
Copy Markdown
Member

Slightly related, i just noticed that on YouTube, Its possible to select Public videos on the videos tab. Would it be possible to directly fetch Public videos for displaying it on the videos tab instead of fetching all and then filtering them?

Edit: What this PR is doing is already a good improvement but its also possible that there are e.g 6 pages full of member only content before public videos are getting displayed. So clicking 6 times on a fetch more button isnt a very good UX

Comment thread src/renderer/views/Channel/Channel.vue Outdated
@Shadorc

Shadorc commented Sep 13, 2026

Copy link
Copy Markdown
Contributor Author

@efb4f5ff-1298-471a-8973-3d47447115dc It can't be done directly, it requires one additional request.
It could be done in Channel.vue line 1141, when we detect that no videos were retrieved but more are available.
What do you think?

Code snippet prototype:

if (latestVideos.value.length === 0 && videosTab.has_continuation) {
  const get_public_videos = videosTab.memo.getType(YTNodes.ChipView).filter(item => item.text === "Public")[0].tap_command
  if (get_public_videos.is(YTNodes.NavigationEndpoint)) {
    const result = await get_public_videos.call(videosTab.actions, { parse: true });
    console.log('public videos', result.on_response_received_actions_memo.getType(YTNodes.LockupView))
  }
}

@efb4f5ff-1298-471a-8973-3d47447115dc

Copy link
Copy Markdown
Member

Lets wait for the Code Owners to chime in on it

Comment thread src/renderer/views/Channel/Channel.vue
@efb4f5ff-1298-471a-8973-3d47447115dc

Copy link
Copy Markdown
Member

@PikachuEXE any thoughts on #9791 (comment)

@PikachuEXE

Copy link
Copy Markdown
Member

I think that belongs to another PR and potentially requires changes to YTJS (better not do too much "internal stuff"

@Shadorc

Shadorc commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author

It indeed could be part of a separate MR. Also, I've missed it, but it is already implemented in ytjs (it is two requests, I would have to dig deeper to only apply the second filter as we don't need the first one, if we chose this):

if (latestVideos.value.length === 0 && videosTab.has_continuation) {
  console.log('public videos', await videosTab.applyFilter('Latest', 'Public'))
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: waiting for review For PRs that are complete, tested, and ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Improve messaging when all channel videos are filtered out

3 participants