Conversation
|
Slightly related, i just noticed that on YouTube, Its possible to select Edit: What this PR is doing is already a good improvement but its also possible that there are e.g 6 pages full of member only content before public videos are getting displayed. So clicking 6 times on a fetch more button isnt a very good UX |
|
@efb4f5ff-1298-471a-8973-3d47447115dc It can't be done directly, it requires one additional request. Code snippet prototype: if (latestVideos.value.length === 0 && videosTab.has_continuation) {
const get_public_videos = videosTab.memo.getType(YTNodes.ChipView).filter(item => item.text === "Public")[0].tap_command
if (get_public_videos.is(YTNodes.NavigationEndpoint)) {
const result = await get_public_videos.call(videosTab.actions, { parse: true });
console.log('public videos', result.on_response_received_actions_memo.getType(YTNodes.LockupView))
}
} |
|
Lets wait for the Code Owners to chime in on it |
|
@PikachuEXE any thoughts on #9791 (comment) |
|
I think that belongs to another PR and potentially requires changes to YTJS (better not do too much "internal stuff" |
|
It indeed could be part of a separate MR. Also, I've missed it, but it is already implemented in ytjs (it is two requests, I would have to dig deeper to only apply the second filter as we don't need the first one, if we chose this): if (latestVideos.value.length === 0 && videosTab.has_continuation) {
console.log('public videos', await videosTab.applyFilter('Latest', 'Public'))
} |
Pull Request Type
Related issue
closes #9678
Description
Add a specific message when a channel contains videos but they were all filtered. This can happen if videos are for members only.
I have removed
This channel does not currently have any videoskey because it can't be displayed. Videos tab is not displayed if there are no videos, see https://github.com/FreeTubeApp/FreeTube/blob/development/src/renderer/views/Channel/Channel.vue#L792Screenshots
Testing
Desktop