Conversation
Shadorc
requested review from
PikachuEXE,
absidue and
radmorecameron
as code owners
September 14, 2026 22:07
github-actions
Bot
added
the
PR: waiting for review
FreeTubeBot
enabled auto-merge (squash)
September 14, 2026 22:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
closes #9804
Description
A few strings were nullable but used without null checks. It was working with Local API but throwing with Invidious.
I'm not sure what is the preferred code style for null check, I like being explicit so I went with
!= nullTesting
Additional context
I find this code a bit confusing as to what properties are nullable and what properties belong to Invidious and/or Local API