Fix compliance findings in Frends.AzureDataLake.DownloadFiles (v2.0.0) - #29
Open
MichalFrends1 with Copilot wants to merge 12 commits into
Open
Fix compliance findings in Frends.AzureDataLake.DownloadFiles (v2.0.0)#29MichalFrends1 with Copilot wants to merge 12 commits into
MichalFrends1 with Copilot wants to merge 12 commits into
Conversation
…sion 2.0.0 - Target net8.0 in both csproj files - Add Input class wrapping Source and Destination (fixes FT0018, FT0007) - Rename IsSuccess to Success, remove ErrorMessage, add Error object (fixes FT0011) - Add ErrorMessageOnFailure to Options (fixes FT0015) - Add summary docs to Constants (fixes FT0014) - Rename cancellation token param to cancellationToken (fixes FT0008) - Add Helpers/ErrorHandler.cs following standard pattern - Update all test call sites to use new API - Replace ErrorHandlingTests with ErrorHandlerTest - Bump version to 2.0.0 (breaking change), update CHANGELOG.md Co-authored-by: MichalFrends1 <167774394+MichalFrends1@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix compliance findings in Frends.AzureDataLake.DownloadFiles
Fix compliance findings in Frends.AzureDataLake.DownloadFiles (v2.0.0)
Aug 13, 2026
Added example usage for AdditionalInfo property.
Added example to the Error property documentation.
…on; remove Source/Destination classes - Input now directly contains all Azure Data Lake connection fields (was in Source) - New Connection class contains destination directory and overwrite flag (was in Destination) - Deleted Source.cs and Destination.cs - Updated DownloadFiles.cs private helpers to operate on Input/Connection directly - Updated all test files to use new flat Input/Connection API - Changed all [ExpectedException(typeof(FormatException/RequestFailedException/...))] to [ExpectedException(typeof(Exception), AllowDerivedTypes = true)] Co-authored-by: MichalFrends1 <167774394+MichalFrends1@users.noreply.github.com>
…nput class in DownloadFiles Co-authored-by: MichalFrends1 <167774394+MichalFrends1@users.noreply.github.com>
… parameter structure Co-authored-by: MichalFrends1 <167774394+MichalFrends1@users.noreply.github.com>
Co-authored-by: MichalFrends1 <167774394+MichalFrends1@users.noreply.github.com>
MichalFrends1
marked this pull request as ready for review
August 13, 2026 11:24
MatteoDelOmbra
requested changes
Aug 14, 2026
MatteoDelOmbra
left a comment
MatteoDelOmbra
left a comment
Contributor
There was a problem hiding this comment.
remove AllowDerivedTypes in all tests- we always return System.Exception
Contributor
|
@copilot Please address the review comments and make the requested changes |
Co-authored-by: MichalFrends1 <167774394+MichalFrends1@users.noreply.github.com>
Contributor
Author
| /// </summary> | ||
| /// <example>c:\temp</example> | ||
| [DisplayFormat(DataFormatString = "Text")] | ||
| public string Directory { get; init; } |
Contributor
There was a problem hiding this comment.
@MichalFrends1 lets specify in parameter name that this id destination directory
| /// </summary> | ||
| /// <example>*.txt</example> | ||
| [DefaultValue("*.txt")] | ||
| public string FilePattern { get; init; } |
Contributor
There was a problem hiding this comment.
@MichalFrends1 lets specify that this is a full path pattern from SOURCE
MatteoDelOmbra
requested changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves all 8 Frends task analyzer findings (FT0007, FT0008, FT0011×2, FT0014, FT0015, FT0018×2) and upgrades the target framework to net8.0.
Breaking changes
DownloadFilesmethod signature:SourceandDestinationare no longer top-level[PropertyTab]parameters — they're now properties of a newInputclass (fixes FT0007, FT0018)Result.IsSuccess→Result.Success;Result.ErrorMessageremoved in favour of a structuredResult.Errorobject (Error.Message,Error.AdditionalInfo) (fixes FT0011)Before:
After:
Other changes
Options.ErrorMessageOnFailureadded — custom error message surfaced on failure (fixes FT0015)token→cancellationToken(fixes FT0008)Constantsclass and enum members documented with XML summaries (fixes FT0014)Helpers/ErrorHandler.csadded following the standard Frends error-handling pattern; error handling in the task method updated accordinglyErrorHandlingTestsreplaced withErrorHandlerTestcovering throw-on-failure, return-on-failure, and custom error message scenariosnet8.0; version bumped to2.0.0