Skip to content

Initial implementation of Frends.AzureDataLake.CreateDirectory. - #8

Open
MichalFrends1 wants to merge 9 commits into
mainfrom
Frends.AzureDataLake.CreateDirectory
Open

Initial implementation of Frends.AzureDataLake.CreateDirectory.#8
MichalFrends1 wants to merge 9 commits into
mainfrom
Frends.AzureDataLake.CreateDirectory

Conversation

@MichalFrends1

Copy link
Copy Markdown
Contributor

Issue 3

@MichalFrends1
MichalFrends1 requested a review from jefim May 14, 2024 08:15
@MichalFrends1 MichalFrends1 self-assigned this May 14, 2024
@github-actions

Copy link
Copy Markdown

CodeQL found vulnerabilities from the code. Check the PR or the workflow summary for the details: https://github.com/FrendsPlatform/Frends.AzureDataLake/actions/runs/9076352041?pr=8

@github-actions

Copy link
Copy Markdown

CodeQL found vulnerabilities from the code. Check the PR or the workflow summary for the details: https://github.com/FrendsPlatform/Frends.AzureDataLake/actions/runs/9096095485?pr=8

public async Task AccessTokenAuthenticationTest()
{
var containerName = $"test{Guid.NewGuid()}";
var directoryName = $"test{Guid.NewGuid()}";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that those are not getting cleaned up after the test

@github-actions

Copy link
Copy Markdown

CodeQL found vulnerabilities from the code. Check the PR or the workflow summary for the details: https://github.com/FrendsPlatform/Frends.AzureDataLake/actions/runs/9170232601?pr=8

@github-actions

Copy link
Copy Markdown

Great job!

@github-actions

Copy link
Copy Markdown

Great job!

@jefim jefim assigned jefim and unassigned MichalFrends1 May 22, 2024
@jefim jefim linked an issue May 22, 2024 that may be closed by this pull request
{
"Tasks": [
{
"TaskMethod": "Frends.AzureDataLake.CreateDirectory"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be Frends.AzureDataLake.CreateDirectory.AzureDataLake.CreateDirectory, because
Frends.AzureDataLake.CreateDirectory = namespace
AzureDataLake = class name
CreateDirectory = method name.

The syntax for metadata file is: {{NAMESPACE}}.{{CLASS}}.{{METHOD}}

{
var containerName = $"test{Guid.NewGuid()}";
var directoryName = $"test{Guid.NewGuid()}";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think those are still not being cleaned up

@github-actions

Copy link
Copy Markdown

Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Frends.AzureDataLake.CreateDirectory

3 participants