Initial implementation of Frends.AzureDataLake.CreateDirectory. - #8
Initial implementation of Frends.AzureDataLake.CreateDirectory.#8MichalFrends1 wants to merge 9 commits into
Conversation
|
CodeQL found vulnerabilities from the code. Check the PR or the workflow summary for the details: https://github.com/FrendsPlatform/Frends.AzureDataLake/actions/runs/9076352041?pr=8 |
|
CodeQL found vulnerabilities from the code. Check the PR or the workflow summary for the details: https://github.com/FrendsPlatform/Frends.AzureDataLake/actions/runs/9096095485?pr=8 |
| public async Task AccessTokenAuthenticationTest() | ||
| { | ||
| var containerName = $"test{Guid.NewGuid()}"; | ||
| var directoryName = $"test{Guid.NewGuid()}"; |
There was a problem hiding this comment.
I think that those are not getting cleaned up after the test
|
CodeQL found vulnerabilities from the code. Check the PR or the workflow summary for the details: https://github.com/FrendsPlatform/Frends.AzureDataLake/actions/runs/9170232601?pr=8 |
|
Great job! |
|
Great job! |
| { | ||
| "Tasks": [ | ||
| { | ||
| "TaskMethod": "Frends.AzureDataLake.CreateDirectory" |
There was a problem hiding this comment.
This should probably be Frends.AzureDataLake.CreateDirectory.AzureDataLake.CreateDirectory, because
Frends.AzureDataLake.CreateDirectory = namespace
AzureDataLake = class name
CreateDirectory = method name.
The syntax for metadata file is: {{NAMESPACE}}.{{CLASS}}.{{METHOD}}
| { | ||
| var containerName = $"test{Guid.NewGuid()}"; | ||
| var directoryName = $"test{Guid.NewGuid()}"; | ||
|
|
There was a problem hiding this comment.
I think those are still not being cleaned up
|
Great job! |
Issue 3