Fix compliance findings in Frends.Pdf.Create (FT0007, FT0011, FT0014, FT0015, FT0018) - #22
Merged
MichalFrends1 merged 7 commits intoAug 19, 2026
Conversation
…, FT0014, FT0015, FT0018) Co-authored-by: MatteoDelOmbra <44415151+MatteoDelOmbra@users.noreply.github.com>
…coverage Co-authored-by: MatteoDelOmbra <44415151+MatteoDelOmbra@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix compliance findings in Frends.Pdf.Create
Fix compliance findings in Frends.Pdf.Create (FT0007, FT0011, FT0014, FT0015, FT0018)
Aug 17, 2026
MatteoDelOmbra
requested changes
Aug 17, 2026
MatteoDelOmbra
left a comment
Contributor
There was a problem hiding this comment.
@copilot go through comments and resolve them accordingly
….AdditionalInfo type, use parameterless Result constructor, add test GlobalSuppressions Co-authored-by: MatteoDelOmbra <44415151+MatteoDelOmbra@users.noreply.github.com>
Co-authored-by: MatteoDelOmbra <44415151+MatteoDelOmbra@users.noreply.github.com>
MatteoDelOmbra
approved these changes
Aug 17, 2026
MatteoDelOmbra
marked this pull request as ready for review
August 17, 2026 11:35
MichalFrends1
requested changes
Aug 19, 2026
MatteoDelOmbra
approved these changes
Aug 19, 2026
MichalFrends1
approved these changes
Aug 19, 2026
MichalFrends1
deleted the
copilot/fix-compliance-findings-frends-pdf-create
branch
August 19, 2026 11:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves 18 FrendsTaskAnalyzer findings in
Frends.Pdf.Createby aligning the task with current platform standards.Breaking changes (→ v3.0.0)
Method signature — the three separate
[PropertyTab]parameters (FileProperties,DocumentSettings,DocumentContent) were not recognized platform types (FT0018) andInput/CancellationTokenwere missing (FT0007). They are now consolidated:Inputgroups the three former parameters asOutputFile,DocumentSettings, andContent.Non-breaking additions
Options.ErrorMessageOnFailure(FT0015) — allows overriding the thrown/returned error message.Result.Error(FT0011) — populated with message and inner exception whenThrowErrorOnFailure = false.Helpers/ErrorHandler— standard platform pattern; all exceptions inCreate()now route throughexception.Handle(options)instead of hand-rolledif (ThrowErrorOnFailure) throw.<summary>and<example>to all flagged properties/methods inFontMetadata,Extensions, andFileFontResolver(FT0014).Project / tooling
FrendsTaskMetadata.jsonchanged from<None>to<AdditionalFiles>(required by FrendsTaskAnalyzers for FT0020).StyleCop.AnalyzersandFrendsTaskAnalyzerspackage references; addedGlobalSuppressions.cswith standard Frends suppressions.Tests
Input-based call site.FileNotFoundExceptionupdated toException— the ErrorHandler wraps all exceptions innew Exception(message, innerEx).ErrorHandlerTestadded covering: throw on failure, return failed result, custom error message (throw and return paths).