build: raise the numpy floor to 1.22 - #225
Merged
Merged
Conversation
The numpy 1.21.6 wheel bundles an OpenBLAS that segfaults on BLAS-backed matrix multiplies on current Apple Silicon Macs (reproduced on an M5 with macOS 26), even with OPENBLAS_NUM_THREADS=1 or an OPENBLAS_CORETYPE override. numpy 1.22.0 through 2.0.2 run the same workload cleanly, and every supported Python (>=3.9) has 1.22 wheels, so the old floor only admitted a broken install.
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
numpy>=1.21let resolvers install numpy 1.21.6. The OpenBLAS bundled in that wheel segfaults (SIGSEGV, or SIGBUS once scipy's OpenBLAS is also loaded) on the first BLAS-backed matrix multiply on current Apple Silicon. This showed up locally as repeatedlibopenblasdgemmcrash reports from minimum-dependency test envs.Reproduced on an M5 MacBook Air, macOS 26.6.2, Python 3.9.6, with a 1500×384 float
v @ v.T:OPENBLAS_NUM_THREADS=1OPENBLAS_CORETYPE=ARMV8/NEOVERSEN1Every Python freshdata supports (>=3.9) has numpy 1.22 wheels, so the new floor excludes only the broken release line.
Changes:
pyproject.toml:numpy>=1.21→numpy>=1.22.uv.lock: refreshed withmake constraints. Only the specifier line changed;constraints/ci.txtpins are unchanged.CHANGELOG.md: entry under Unreleased → Fixed.Test plan
fd.clean(default andsemantic_mode="assist") plus a 1500×1500 matmul on numpy 1.22.0 / pandas 1.5.0 / Python 3.9make constraintsleavesconstraints/ci.txtunchanged, so the lockfile job should pass