fix(masking): validate unmatched columns and support snake_case matching - #269
Open
Voyagerroc-Lab wants to merge 1 commit into
Open
Voyagerroc-Lab wants to merge 1 commit into
Voyagerroc-Lab wants to merge 1 commit into
Conversation
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR addresses #251 by handling unmatched and variant column names in masking rules:
_resolve_columnsnow matches rule columns against DataFrame columns using both exact names and snake_case normalization (snake_case(col)), ensuring common casing variants (like--mask Email:hashforemail, orFirst Nameforfirst_name) resolve correctly.strict: bool = Truefield toMaskingRuleandstrict: bool | None = Noneparameter tomask_dataframe.rule.columnsare provided and any are missing from the DataFrame,ValueErroris raised in strict mode (the default), causing the CLI to exit with code 1 and a descriptive error message instead of silently exiting 0 with unmasked data.unmatched_columns: list[str]toMaskReportand included it inMaskReport.to_dict(), capturing any unmatched columns for compliance and auditing when running in non-strict mode.tests/test_enterprise_cleaner.pyfor snake_case column matching, strictValueErrorraising on missing columns, and non-strict tracking inMaskReport.unmatched_columns.tests/test_enterprise_cli.pyverifying--mask Email:hashsuccessfully masksemailand--mask non_existent:hashexits with code 1 and an informative error message.Closes #251