Conversation
There was a problem hiding this comment.
Pull request overview
Adds a safety check in the zip install path to prevent running directory creation/cleanup logic when TARGET_DIR is invalid, reducing the risk of destructive rm -rf operations against unintended paths.
Changes:
- Added a guard in
install_zip()to exit early whenTARGET_DIRis empty. - Minor whitespace adjustment in the cleanup branch.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+35
to
+38
| if [ -z "${TARGET_DIR}" ]; then | ||
| echo "Need to set TARGET_DIR to a valid directory. Set it and try again." | ||
| exit 1 | ||
| fi |
Author
There was a problem hiding this comment.
Unlikely that a user would set TARGET_DIR to /, but otherwise no pushback from me on this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents the installer from continuing when
TARGET_DIRresolves to an empty value before it creates or removes install directories.Without this guard, the cleanup step can expand paths like
$TARGET_DIR/binto/bin.